[SYCL] Fix device aspect macro header CMake dependency (#17358)

npmiller · web-flow · commit b9324eb91f7d · 2025-03-10T14:58:58.000Z
Without this patch the header wasn't getting re-generated when the
`.def` files are changed, which causes build failures on existing builds
when new aspects are introduced.
diff --git a/sycl/CMakeLists.txt b/sycl/CMakeLists.txt
@@ -200,6 +200,8 @@ add_custom_command(
   COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/source/device_aspect_macros_generator.py ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl ${SYCL_INCLUDE_BUILD_DIR}/sycl
   OUTPUT  ${SYCL_INCLUDE_BUILD_DIR}/sycl/device_aspect_macros.hpp
   COMMENT "Generating device_aspect_macros.hpp"
+  DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl/info/aspects.def
+          ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl/info/aspects_deprecated.def
 )
 
 add_custom_target(sycl-device-aspect-macros-header

Original file line number	Diff line number	Diff line change
`@@ -200,6 +200,8 @@ add_custom_command(`
`200`	`200`	`COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/source/device_aspect_macros_generator.py ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl ${SYCL_INCLUDE_BUILD_DIR}/sycl`
`201`	`201`	`OUTPUT ${SYCL_INCLUDE_BUILD_DIR}/sycl/device_aspect_macros.hpp`
`202`	`202`	`COMMENT "Generating device_aspect_macros.hpp"`
	`203`	`+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl/info/aspects.def`
	`204`	`+ ${CMAKE_CURRENT_SOURCE_DIR}/include/sycl/info/aspects_deprecated.def`
`203`	`205`	`)`
`204`	`206`
`205`	`207`	`add_custom_target(sycl-device-aspect-macros-header`