[SYCL] Addressing feedback from reviewers

Signed-off-by: Ruyman Reyes <[email protected]>

Author: Ruyk

sycl/source/detail/platform_impl.cpp

@@ -21,6 +21,13 @@ namespace sycl {
 namespace detail {
 
 static bool IsBannedPlatform(platform Platform) {
+  // The NVIDIA OpenCL platform is currently not compatible with DPC++
+  // since it is only 1.2 but gets selected by default in many systems
+  // There is also no support on the PTX backend for OpenCL consumption,
+  // and there have been some internal reports.
+  // To avoid problems on default users and deployment of DPC++ on platforms
+  // where CUDA is available, the OpenCL support is disabled.
+  //
   auto IsNVIDIAOpenCL = [](platform Platform) {
     if (Platform.is_host())
       return false;
@@ -29,7 +36,13 @@ static bool IsBannedPlatform(platform Platform) {
                              "NVIDIA CUDA") != std::string::npos;
     const auto Backend =
         detail::getSyclObjImpl(Platform)->getPlugin().getBackend();
-    return (HasCUDA && Backend == backend::opencl);
+    const bool IsCUDAOCL = (HasCUDA && Backend == backend::opencl);
+    if (detail::pi::trace(detail::pi::TraceLevel::PI_TRACE_ALL) && IsCUDAOCL) {
+      std::cout << "SYCL_PI_TRACE[all]: "
+                << "NVIDIA CUDA OpenCL platform found but is not compatible."
+                << std::endl;
+    }
+    return IsCUDAOCL;
   };
   return IsNVIDIAOpenCL(Platform);
 }

sycl/source/detail/program_manager/program_manager.cpp

@@ -88,7 +88,8 @@ static RT::PiProgram createBinaryProgram(const ContextImplPtr Context,
 
   // TODO: Implement `piProgramCreateWithBinary` to not require extra logic for
   //       the CUDA backend.
-  if (Context->getPlugin().getBackend() == backend::cuda) {
+  const auto Backend = Context->getPlugin().getBackend();
+  if (Backend == backend::cuda) {
     // TODO: Reemplace CreateWithSource with CreateWithBinary in CUDA backend
     const char *SignedData = reinterpret_cast<const char *>(Data);
     Plugin.call<PiApiKind::piclProgramCreateWithSource>(Context->getHandleRef(), 1 /*one binary*/, &SignedData,