Skip to content

Commit bce4201

Browse files
author
Hugh Delaney
committed
Respond to comments
1 parent 9d3400e commit bce4201

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

sycl/doc/EnvironmentVariables.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,18 @@ SYCL runtime this can change the stride offset of different dimensions. Range
204204
rounding will only be used if the SYCL runtime X dimension exceeds 32, which
205205
is a magic number chosen by the SYCL runtime.
206206

207-
Generation of range rounded kernels can be disabled by defining the macro
208-
`__SYCL_DISABLE_PARALLEL_FOR_RANGE_ROUNDING__` at compile time. The macro must
209-
be defined before `#include <sycl/sycl.hpp>`.
207+
Generation of range rounded kernels can be disabled by using the compiler flag
208+
`-fsycl-disable-range-rounding`.
210209

211210
### Range Rounding Environment Variables
212211

213212
| Environment variable | Values | Description |
214213
| -------------------- | ------ | ----------- |
215214
| `SYCL_DISABLE_PARALLEL_FOR_RANGE_ROUNDING` | Any(\*) | Disables automatic rounding-up of `parallel_for` invocation ranges. |
216215
| `SYCL_PARALLEL_FOR_RANGE_ROUNDING_TRACE` | Any(\*) | Enables tracing of `parallel_for` invocations with rounded-up ranges. |
216+
| `SYCL_PARALLEL_FOR_RANGE_ROUNDING_PARAMS` | `MinFactorX:GoodFactor:MinRangeX` | `MinFactorX`: The minimum range that the rounded range should be a multiple of (Default 16) |
217+
| | | `GoodFactor`: The preferred range that the rounded range be a multiple of (Default 32) |
218+
| | | `MinRangeX`: The minimum X dimension of the range such that range rounding is activated (Default 1024) |
217219

218220

219221
## Controlling DPC++ Level Zero Plugin

sycl/doc/PreprocessorMacros.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,6 @@ This file describes macros that have effect on SYCL compiler and run-time.
4848
support for `assert()` via `aspect::ext_oneapi_native_assert`.
4949
This macro is undefined by default.
5050

51-
- **__SYCL_DISABLE_PARALLEL_FOR_RANGE_ROUNDING__**
52-
53-
Defining this macro disables the automatic generation of a range rounded
54-
kernel for `sycl::range` kernels. The macro must be defined before
55-
`#include <sycl/sycl.hpp>`. Using this macro may reduce device binary size if
56-
`sycl::range` kernels are used.
57-
5851
- **SYCL2020_CONFORMANT_APIS (deprecated)**
5952
This macro is used to comply with the SYCL 2020 specification, as some of the current
6053
implementations may be widespread and not conform to it.

sycl/include/sycl/handler.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1139,7 +1139,7 @@ class __SYCL_EXPORT handler {
11391139
// Range should be a multiple of this for improved performance.
11401140
size_t GoodFactor = 32;
11411141
// Range should be at least this to make rounding worthwhile.
1142-
size_t MinRangeX = 32;
1142+
size_t MinRangeX = 1024;
11431143

11441144
// Check if rounding parameters have been set through environment:
11451145
// SYCL_PARALLEL_FOR_RANGE_ROUNDING_PARAMS=MinRound:PreferredRound:MinRange

0 commit comments

Comments
 (0)