Skip to content

Commit bd1250f

Browse files
authored
[ITT][SYCL][NFC] Update ITT instrumentation tests (#10874)
Minor fixes in -fsycl-instrument-device-code option tests: 1. Remove Doxygen style comments from the tests 2. Remove run command duplicate from clang/test/Driver/sycl-instrumentation.c 3. Update SYCL include header to SYCL 2020 in barrer.cpp test.
1 parent eaa436f commit bd1250f

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

clang/test/CodeGenSYCL/kernel-simple-instrumentation.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
/// Check if start/finish ITT annotations are being added during compilation of
2-
/// SYCL device code
1+
// Check if start/finish ITT annotations are being added during compilation of
2+
// SYCL device code
33

4-
// RUN: %clang_cc1 -fsycl-is-device -fsycl-instrument-device-code -triple spir64-unknown-unknown -emit-llvm %s -o - | FileCheck %s
54
// RUN: %clang_cc1 -fsycl-is-device -fsycl-instrument-device-code -triple spir64-unknown-unknown -emit-llvm %s -o - | FileCheck %s
65

76
// CHECK: kernel_function
Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
/// Check if -fsycl-instrument-device-code is passed to device-side -cc1
2-
/// and if ITT device libraries are pulled in.
3-
/// The following conditions must be fulfilled:
4-
/// 1. A SPIR-V-based environment must be targetted
5-
/// 2. The option must not be explicitly disabled in the Driver call
1+
// Check if -fsycl-instrument-device-code is passed to device-side -cc1
2+
// and if ITT device libraries are pulled in.
3+
// The following conditions must be fulfilled:
4+
// 1. A SPIR-V-based environment must be targetted
5+
// 2. The option must not be explicitly disabled in the Driver call
6+
7+
// FIXME: Force linux targets to allow for the libraries to be found. Dummy
8+
// inputs for --sysroot should be updated to work better for Windows.
69

7-
/// FIXME: Force linux targets to allow for the libraries to be found. Dummy
8-
/// inputs for --sysroot should be updated to work better for Windows.
910
// RUN: %clangxx -target x86_64-unknown-linux-gnu -fsycl --sysroot=%S/Inputs/SYCL -fsycl-targets=spir64 -### %s 2>&1 \
1011
// RUN: | FileCheck -check-prefixes=CHECK-SPIRV,CHECK-HOST %s
11-
/// -fno-sycl-device-lib mustn't affect the linkage of ITT libraries
12+
// -fno-sycl-device-lib mustn't affect the linkage of ITT libraries
1213
// RUN: %clangxx -target x86_64-unknown-linux-gnu -fsycl --sysroot=%S/Inputs/SYCL -fno-sycl-device-lib=all -fsycl-targets=spir64 -### %s 2>&1 \
1314
// RUN: | FileCheck -check-prefixes=CHECK-SPIRV %s
1415

@@ -23,5 +24,6 @@
2324
// RUN: | FileCheck -check-prefixes=CHECK-NONPASSED %s
2425
// RUN: %clangxx -fsycl -fsycl-targets=nvptx64-nvidia-cuda -fno-sycl-instrument-device-code -nocudalib -### %s 2>&1 \
2526
// RUN: | FileCheck -check-prefixes=CHECK-NONPASSED %s
27+
2628
// CHECK-NONPASSED-NOT: "-fsycl-instrument-device-code"
2729
// CHECK-NONPASSED-NOT: "-input={{.*}}libsycl-itt-{{.*}}.{{o|obj}}"

sycl/test-e2e/DeviceLib/ITTAnnotations/barrier.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// RUN: %{build} -fsycl-instrument-device-code -o %t.out
22
// RUN: %{run} %t.out
33

4-
#include "CL/sycl.hpp"
4+
#include "sycl/sycl.hpp"
55
#include <vector>
66

77
using namespace sycl;

0 commit comments

Comments
 (0)