Skip to content

Commit c001520

Browse files
authored
[DeviceASAN] Enable e2e test "private_nullptr.cpp" (#15995)
1 parent 347c2e6 commit c001520

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
// RUN: %{build} %device_asan_flags -O2 -g -o %t3.out
77
// RUN: %{run} not %t3.out 2>&1 | FileCheck %s
88

9-
// FIXME: There's an issue in gfx driver, so this test pending here.
10-
// XFAIL: *
11-
129
#include <sycl/detail/core.hpp>
1310
#include <sycl/ext/oneapi/experimental/address_cast.hpp>
1411

@@ -22,15 +19,14 @@ int main() {
2219
sycl::nd_range<1>(N, 1), [=](sycl::nd_item<1> item) {
2320
auto private_array =
2421
sycl::ext::oneapi::experimental::static_address_cast<
25-
sycl::access::address_space::private_space,
26-
sycl::access::decorated::no>(array);
22+
sycl::access::address_space::private_space>(array);
2723
private_array[0] = 0;
2824
});
2925
Q.wait();
3026
});
3127
// CHECK: ERROR: DeviceSanitizer: null-pointer-access on Unknown Memory
3228
// CHECK: WRITE of size 4 at kernel {{<.*MyKernel>}} LID(0, 0, 0) GID({{.*}}, 0, 0)
33-
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-5]]
29+
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-6]]
3430

3531
return 0;
3632
}

sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,12 @@
5151
// tests to match the required format and in that case you should just update
5252
// (i.e. reduce) the number and the list below.
5353
//
54-
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 142
54+
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 141
5555
//
5656
// List of improperly XFAIL-ed tests.
5757
// Remove the CHECK once the test has been properly XFAIL-ed.
5858
//
59-
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
60-
// CHECK-NEXT: Basic/aspects.cpp
59+
// CHECK: Basic/aspects.cpp
6160
// CHECK-NEXT: Basic/buffer/reinterpret.cpp
6261
// CHECK-NEXT: Basic/device_event.cpp
6362
// CHECK-NEXT: Basic/diagnostics/handler.cpp

0 commit comments

Comments
 (0)