Fix Coverity dereference before null check issue (#13456)

julianmi · Bensuo · web-flow · commit c02f915d42ac · 2024-04-17T15:37:48.000+02:00
Fixes an issue found by Coverity in `addEventForNode` about
dereferencing the `EventImpl` before a null check.

---------

Co-authored-by: Ben Tracy &lt;ben.tracy@codeplay.com&gt;
diff --git a/sycl/source/detail/graph_impl.hpp b/sycl/source/detail/graph_impl.hpp
@@ -899,7 +899,7 @@ class graph_impl {
   void addEventForNode(std::shared_ptr<graph_impl> GraphImpl,
                        std::shared_ptr<sycl::detail::event_impl> EventImpl,
                        std::shared_ptr<node_impl> NodeImpl) {
-    if (!(EventImpl->getCommandGraph()))
+    if (EventImpl && !(EventImpl->getCommandGraph()))
       EventImpl->setCommandGraph(GraphImpl);
     MEventsMap[EventImpl] = NodeImpl;
   }

Original file line number	Diff line number	Diff line change
`@@ -899,7 +899,7 @@ class graph_impl {`
`899`	`899`	`void addEventForNode(std::shared_ptr<graph_impl> GraphImpl,`
`900`	`900`	`std::shared_ptr<sycl::detail::event_impl> EventImpl,`
`901`	`901`	`std::shared_ptr<node_impl> NodeImpl) {`
`902`		`- if (!(EventImpl->getCommandGraph()))`
	`902`	`+ if (EventImpl && !(EventImpl->getCommandGraph()))`
`903`	`903`	`EventImpl->setCommandGraph(GraphImpl);`
`904`	`904`	`MEventsMap[EventImpl] = NodeImpl;`
`905`	`905`	`}`