Skip to content

Commit c11621f

Browse files
authored
Enable InvokeSimd/call_vadd_1d_loop for PVC, disable InvokeSimd popcnt tests (#8970)
Driver issue fixed some time ago. Recently it started to pass 'unexpectedly' in some CIs.
1 parent f5a062d commit c11621f

File tree

5 files changed

+12
-13
lines changed

5 files changed

+12
-13
lines changed

sycl/test-e2e/InvokeSimd/Feature/ImplicitSubgroup/popcnt.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
// REQUIRES: gpu && linux
33
// UNSUPPORTED: cuda || hip
44
//
5-
// TODO: enable after simd_mask supported
6-
// XFAIL: gpu
5+
// NOTE: The feature is not yet supported, there is a discussion on the
6+
// feasibility of tests
7+
// REQUIRES: TEMPORARY_DISABLED
78
//
89
// Check that full compilation works:
910
// RUN: %clangxx -DIMPL_SUBGROUP -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %S/../popcnt.cpp -o %t.out

sycl/test-e2e/InvokeSimd/Feature/popcnt.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
// REQUIRES: gpu && linux
33
// UNSUPPORTED: cuda || hip
44
//
5-
// TODO: enable after simd_mask supported
6-
// XFAIL: gpu
5+
// NOTE: The feature is not yet supported, there is a discussion on the
6+
// feasibility of tests
7+
// REQUIRES: TEMPORARY_DISABLED
78
//
89
// Check that full compilation works:
910
// RUN: %clangxx -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out

sycl/test-e2e/InvokeSimd/Regression/call_vadd_1d_loop.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// REQUIRES: gpu && linux
33
// UNSUPPORTED: cuda || hip
44
//
5-
// TODO: enable when Jira ticket resolved
6-
// XFAIL: gpu-intel-pvc
7-
//
85
// Check that full compilation works:
96
// RUN: %clangxx -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out
107
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %GPU_RUN_PLACEHOLDER %t.out

sycl/test-e2e/InvokeSimd/Regression/nbarrier_exec_in_order.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ ESIMD_INLINE void ESIMD_CALLEE_nbarrier(int localID,
5757
esimd::simd<int, VL> val(localID);
5858

5959
if constexpr (UseSLM) {
60-
/* TODO: SLM has to be allocated of outside invoke_simd, but propper
61-
* intarface is not yet ready. Current test implementation in this regard
62-
* is a subject to future changes.
60+
/* TODO: SLM needs to be allocated from outside invoke_simd, but the proper
61+
* intarface is not yet ready. Current test implementation in this regard is
62+
* subject to future changes.
6363
*/
6464
esimd::slm_init(Size * sizeof(int));
6565
esimd::simd<int, VL> zero(0);

sycl/test-e2e/InvokeSimd/Regression/slm_load_store.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ constexpr int slm_size = 32 * 1024;
4545

4646
ESIMD_INLINE void slm_load_store_test(nd_item<1> *ndi, dtype *A,
4747
dtype *C) SYCL_ESIMD_FUNCTION {
48-
/* TODO: SLM has to be allocated of outside invoke_simd, but propper
49-
* intarface is not yet ready. Current test implementation in this regard
50-
* is a subject to future changes.
48+
/* TODO: SLM needs to be allocated from outside invoke_simd, but the proper
49+
* intarface is not yet ready. Current test implementation in this regard is
50+
* subject to future changes.
5151
*/
5252
esimd::slm_init<slm_size>();
5353

0 commit comments

Comments
 (0)