Skip to content

Commit c1b4d1f

Browse files
committed
[SYCL][Graph][HIP] Set minimum ROCm version for graphs
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
1 parent 9876e19 commit c1b4d1f

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

sycl/doc/design/CommandGraph.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,10 @@ The HIP backend offers a Graph managemenet API very similar to CUDA Graph
405405
feature for batching series of operations.
406406
The SYCL Graph HIP backend implementation is therefore very similar to that of CUDA.
407407

408+
The minimum version of ROCm required to support `sycl_ext_oneapi_graph` is 5.5.1.
409+
408410
UR commands (e.g. kernels) are mapped as graph nodes using the
409-
[HIP Management API](https://docs.amd.com/projects/HIP/en/docs-5.5.0/doxygen/html/group___graph.html).
411+
[HIP Management API](https://rocm.docs.amd.com/projects/HIP/en/docs-5.5.1/doxygen/html/group___graph.html).
410412
Synchronization between commands (UR sync-points) is implemented
411413
using graph dependencies.
412414
Executable HIP Graphs can be submitted to a HIP stream

sycl/plugins/unified_runtime/CMakeLists.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
8282
endfunction()
8383

8484
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
85-
# commit ed1f8bf618c88eaabea6bde0f6c06fc265f3b49f
86-
# Merge: ca5c3421 69c43b45
87-
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
88-
# Date: Tue Mar 19 21:00:20 2024 +0000
89-
# Merge pull request #1326 from hdelan/refactor-guess-local-worksize
90-
# [CUDA][HIP] Fix bug in guess local worksize funcs and improve local worksize guessing in HIP adapter
91-
set(UNIFIED_RUNTIME_TAG ed1f8bf618c88eaabea6bde0f6c06fc265f3b49f)
85+
# commit 5f4dd113824e90522d813420932c14072dc3049d
86+
# Merge: ed1f8bf b551c77
87+
# Author: Ewan Crawford <ewan@codeplay.com>
88+
# Date: Fri Mar 15 10:22:39 2024 +0000
89+
# Merge pull request #1447 from Bensuo/ewan/rocm_5_5_1
90+
# [HIP][CMDBUF] Require ROCm 5.5.1 for HIP command-buffers
91+
set(UNIFIED_RUNTIME_TAG 5f4dd113824e90522d813420932c14072dc3049d)
9292

9393
if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
9494
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")

0 commit comments

Comments
 (0)