Skip to content

Commit c455b6f

Browse files
authored
[SYCL][E2E][Bindless] Fix -Werror issues (#14912)
Consists of two parts: 1. Fix the setting of `-Werror` on Windows in general for E2E tests * Just appending to `SYCL_E2E_CLANG_CXX_FLAGS` adds an extra semicolon that causes the command line to fail 3. Address remaining `-Werror` failures in Bindless Images E2E tests * Add return from function, even though there's an `assert(false)`
1 parent 232c95c commit c455b6f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

sycl/test-e2e/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ if(MSVC AND NOT SYCL_TEST_E2E_STANDALONE)
6060
else()
6161
set(SYCL_E2E_CLANG_CXX_FLAGS ${CMAKE_CXX_FLAGS})
6262
endif()
63-
list(APPEND SYCL_E2E_CLANG_CXX_FLAGS "-Werror")
63+
64+
set(SYCL_E2E_CLANG_CXX_FLAGS "${SYCL_E2E_CLANG_CXX_FLAGS} -Werror")
6465

6566
if(SYCL_TEST_E2E_STANDALONE)
6667
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in"

sycl/test-e2e/bindless_images/helpers/sampling.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -662,6 +662,7 @@ read(sycl::range<2> globalSize, sycl::vec<float, 2> coords, float offset,
662662
}
663663
}
664664
assert(false && "Invalid sampler encountered!");
665+
return {};
665666
}
666667

667668
}; // namespace sampling_helpers

0 commit comments

Comments
 (0)