[SYCL][E2E] Remove --crash flag from usages of not (#18596)

run-only mode now uses the internal lit shell, so the `--crash` flag is
no longer needed in these tests.

Author: ayylol

sycl/test-e2e/AddressSanitizer/common/print-build-log.cpp

@@ -2,7 +2,7 @@
 // REQUIRES: linux, cpu || (gpu && level_zero)
 // RUN: %{build} %device_asan_flags -DGPU -o %t_gpu.out
 // RUN: %{build} %device_asan_flags -o %t.out
-// RUN: %{run} not --crash %if gpu %{ %t_gpu.out %} %else %{ %t.out %} 2>&1 | FileCheck %s
+// RUN: %{run} not %if gpu %{ %t_gpu.out %} %else %{ %t.out %} 2>&1 | FileCheck %s
 
 #include <iostream>
 #include <sycl/detail/core.hpp>

sycl/test-e2e/AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp

@@ -4,25 +4,13 @@
 // sycl-toolchain is built with assertions enabled, then we hit one at
 // `DeviceGlobalUSMMem::~DeviceGlobalUSMMem()` and exit with abort. If not, then
 // sanitizer does `exit(1)`.
-//
-// That doesn't matter as long as LIT does *not* use "external shell", but when
-// it does, the difference between `not` and `not --crash` becomes crucial and
-// we cannot have a single command that would match both behaviors. Ideally,
-// we'd need to make a choice based on how the toolchain was built.
-// Unfortunately, we don't have that information at the LIT level and
-// propagating it all the way down to it would be ugly. Instead, rely on the
-// fact that "no-assertion" mode doesn't use "run-only" lit invocations and make
-// a choice based on that. This is rather fragile but workarounds the issue for
-// the time being.
-
-// DEFINE: %{not} = not %if run-mode && !build-mode %{ --crash %}
 
 // RUN: %{build} %device_asan_flags -O0 -g -o %t1.out
-// RUN: %{run} %{not} %t1.out 2>&1 | FileCheck %s
+// RUN: %{run} not %t1.out 2>&1 | FileCheck %s
 // RUN: %{build} %device_asan_flags -O1 -g -o %t2.out
-// RUN: %{run} %{not} %t2.out 2>&1 | FileCheck %s
+// RUN: %{run} not %t2.out 2>&1 | FileCheck %s
 // RUN: %{build} %device_asan_flags -O2 -g -o %t3.out
-// RUN: %{run} %{not} %t3.out 2>&1 | FileCheck %s
+// RUN: %{run} not %t3.out 2>&1 | FileCheck %s
 
 // Flakily timesout on PVC
 // UNSUPPORTED: arch-intel_gpu_pvc

sycl/test-e2e/OneapiDeviceSelector/illegal_input.cpp

@@ -1,15 +1,15 @@
 
 // RUN: %clangxx -fsycl %{sycl_target_opts} %S/Inputs/trivial.cpp -o %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="macaroni:*" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR=":" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:." %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="macaroni_level_zero:." %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:macaroni_gpu" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:0..0" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:::gpu" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="level_zero:.1" %{run-unfiltered-devices} %t.out
-// RUN: not --crash env ONEAPI_DEVICE_SELECTOR="" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="macaroni:*" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR=":" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:." %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="macaroni_level_zero:." %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:macaroni_gpu" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:0..0" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:::gpu" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="level_zero:.1" %{run-unfiltered-devices} %t.out
+// RUN: not env ONEAPI_DEVICE_SELECTOR="" %{run-unfiltered-devices} %t.out
 
 // Calling ONEAPI_DEVICE_SELECTOR with an illegal input should result in an
 // error.

sycl/test-e2e/Tracing/usm/queue_copy_released_pointer.cpp

@@ -1,6 +1,6 @@
 // UNSUPPORTED: windows || hip
 // RUN: %{build} -o %t.out
-// RUN: not --crash env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
+// RUN: not env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
 
 // Test parameter analysis of USM function
 

sycl/test-e2e/Tracing/usm/queue_single_task_nullptr.cpp

@@ -1,6 +1,6 @@
 // UNSUPPORTED: windows || target-amd
 // RUN: %{build} -o %t.out
-// RUN: not --crash env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
+// RUN: not env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
 
 // Test parameter analysis of USM usage
 

sycl/test-e2e/Tracing/usm/queue_single_task_released_pointer.cpp

@@ -1,6 +1,6 @@
 // UNSUPPORTED: windows || hip
 // RUN: %{build} -o %t.out
-// RUN: not --crash env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
+// RUN: not env SYCL_TRACE_TERMINATE_ON_WARNING=1 %{run} sycl-trace --verify %t.out | FileCheck %s
 
 // Test parameter analysis of USM usage