Skip to content

Commit cff54c8

Browse files
[CI] Remove old lint task (#12308)
We've enabled the upstream community workflow in #12184 after discussion in #12085. It's been doing just fine, so the old can be removed now. We now start the build/tests before format checks are finished, but that shouldn't be a problem thanks to #11941.
1 parent 8846525 commit cff54c8

File tree

4 files changed

+4
-105
lines changed

4 files changed

+4
-105
lines changed

.github/workflows/sycl_linux_build.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -222,13 +222,6 @@ jobs:
222222
cmake --build $GITHUB_WORKSPACE/build --target install-clang-libraries
223223
cmake --build $GITHUB_WORKSPACE/build --target install-llvm-libraries
224224
225-
- name: Install lint utilities
226-
# We install these into our nightly container that CI uses to run lint
227-
# checks.
228-
run: |
229-
cmake --build $GITHUB_WORKSPACE/build --target install-clang-format
230-
cmake --build $GITHUB_WORKSPACE/build --target install-clang-tidy
231-
232225
- name: Pack toolchain
233226
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
234227
run: tar -I '${{ steps.artifact_info.outputs.COMPRESS }}' -cf ${{ steps.artifact_info.outputs.ARCHIVE_NAME }} -C $GITHUB_WORKSPACE/build/install .

.github/workflows/sycl_linux_precommit.yml

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -31,40 +31,9 @@ jobs:
3131
detect_changes:
3232
uses: ./.github/workflows/sycl_detect_changes.yml
3333

34-
lint:
35-
runs-on: [Linux, build]
36-
if: ${{ always() && !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
37-
container:
38-
image: ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:no-drivers
39-
options: -u 1001:1001
40-
steps:
41-
- uses: actions/checkout@v3
42-
with:
43-
sparse-checkout: |
44-
devops/actions/cached_checkout
45-
devops/actions/clang-format
46-
devops/actions/cleanup
47-
- name: Register cleanup after job is finished
48-
uses: ./devops/actions/cleanup
49-
- name: 'PR commits + 2'
50-
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 2 ))" >> "${GITHUB_ENV}"
51-
- uses: ./devops/actions/cached_checkout
52-
with:
53-
path: src
54-
fetch-depth: ${{ env.PR_FETCH_DEPTH }}
55-
ref: ${{ github.event.pull_request.head.sha }}
56-
merge_ref: ''
57-
cache_path: "/__w/repo_cache/"
58-
- name: Run clang-format
59-
uses: ./devops/actions/clang-format
60-
with:
61-
path: src
62-
6334
build:
64-
needs: [lint, detect_changes]
65-
if: |
66-
always()
67-
&& (success() || needs.lint.result == 'skipped')
35+
needs: [detect_changes]
36+
if: always() && success()
6837
uses: ./.github/workflows/sycl_linux_build.yml
6938
with:
7039
build_ref: ${{ github.sha }}

.github/workflows/sycl_windows_precommit.yml

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -33,41 +33,10 @@ jobs:
3333
detect_changes:
3434
uses: ./.github/workflows/sycl_detect_changes.yml
3535

36-
lint:
37-
runs-on: [Linux, build]
38-
if: ${{ always() && !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
39-
container:
40-
image: ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:no-drivers
41-
options: -u 1001:1001
42-
steps:
43-
- uses: actions/checkout@v3
44-
with:
45-
ref: ${{ github.base_ref }}
46-
sparse-checkout: |
47-
devops/actions/cached_checkout
48-
devops/actions/clang-format
49-
devops/actions/cleanup
50-
- name: Register cleanup after job is finished
51-
uses: ./devops/actions/cleanup
52-
- name: 'PR commits + 2'
53-
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 2 ))" >> "${GITHUB_ENV}"
54-
- uses: ./devops/actions/cached_checkout
55-
with:
56-
path: src
57-
fetch-depth: ${{ env.PR_FETCH_DEPTH }}
58-
ref: ${{ github.event.pull_request.head.sha }}
59-
merge_ref: ''
60-
cache_path: "/__w/repo_cache/"
61-
- name: Run clang-format
62-
uses: ./devops/actions/clang-format
63-
with:
64-
path: src
65-
6636
build:
67-
needs: [lint, detect_changes]
37+
needs: [detect_changes]
6838
if: |
69-
always()
70-
&& (success() || needs.lint.result == 'skipped')
39+
always() && success()
7140
&& github.repository == 'intel/llvm'
7241
uses: ./.github/workflows/sycl_windows_build.yml
7342
with:

devops/actions/clang-format/action.yml

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)