Skip to content

Commit d145da8

Browse files
authored
[SYCL] Deprecate get_access for host_accessor in SYCL2020 (#8005)
Deprecate `buffer::get_access` methods for `host_accessor` in SYCL2020.
1 parent 25a3813 commit d145da8

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

sycl/include/sycl/buffer.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,8 @@ class buffer : public detail::buffer_plain,
504504
}
505505

506506
template <access::mode mode>
507+
__SYCL2020_DEPRECATED("get_access for host_accessor is deprecated, please "
508+
"use get_host_access instead")
507509
accessor<T, dimensions, mode, access::target::host_buffer,
508510
access::placeholder::false_t, ext::oneapi::accessor_property_list<>>
509511
get_access(
@@ -531,6 +533,8 @@ class buffer : public detail::buffer_plain,
531533
}
532534

533535
template <access::mode mode>
536+
__SYCL2020_DEPRECATED("get_access for host_accessor is deprecated, please "
537+
"use get_host_access instead")
534538
accessor<T, dimensions, mode, access::target::host_buffer,
535539
access::placeholder::false_t, ext::oneapi::accessor_property_list<>>
536540
get_access(

sycl/test/warnings/sycl_2020_deprecations.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,17 @@ int main() {
6464
size_t BufferSize = Buffer.size();
6565
// expected-warning@+1 {{'get_size' is deprecated: get_size() is deprecated, please use byte_size() instead}}
6666
size_t BufferGetSize = Buffer.get_size();
67+
{
68+
// expected-warning@+2 {{'get_access' is deprecated: get_access for host_accessor is deprecated, please use get_host_access instead}}
69+
// expected-warning@+1 {{'get_access<sycl::access::mode::read_write>' is deprecated: get_access for host_accessor is deprecated, please use get_host_access instead}}
70+
auto acc = Buffer.get_access<sycl::access_mode::read_write>();
71+
}
72+
{
73+
// expected-warning@+3 {{'get_access' is deprecated: get_access for host_accessor is deprecated, please use get_host_access instead}}
74+
// expected-warning@+2 {{'get_access<sycl::access::mode::read_write>' is deprecated: get_access for host_accessor is deprecated, please use get_host_access instead}}
75+
auto acc =
76+
Buffer.get_access<sycl::access_mode::read_write>(sycl::range<1>(0));
77+
}
6778

6879
sycl::vec<int, 2> Vec(1, 2);
6980
// expected-warning@+1{{'get_count' is deprecated: get_count() is deprecated, please use size() instead}}

0 commit comments

Comments
 (0)