Skip to content

Commit d3fad16

Browse files
authored
[SYCL][Driver] Remove -fsycl-esimd-build-host-code (#11211)
Remove the positive option and keep only the negative option. The option was added only a couple of days ago and nobody should be using it. It is a hidden option as well. Based on feedback from #11037 (comment) --------- Signed-off-by: Sarnie, Nick <[email protected]>
1 parent ba4b2c7 commit d3fad16

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

clang/include/clang/Driver/Options.td

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3641,12 +3641,9 @@ defm sycl_esimd_force_stateless_mem : BoolFOption<"sycl-esimd-force-stateless-me
36413641
BothFlags<[], [ClangOption, CLOption, DXCOption, CC1Option], "">>;
36423642
// TODO: Remove this option once ESIMD headers are updated to
36433643
// guard vectors to be device only.
3644-
defm sycl_esimd_build_host_code : BoolFOption<"sycl-esimd-build-host-code",
3645-
LangOpts<"SYCLESIMDBuildHostCode">, DefaultTrue,
3646-
PosFlag<SetTrue, [], [ClangOption], "Build the host implementation of ESIMD functions."
3647-
"Enabled by default.">,
3648-
NegFlag<SetFalse, [], [ClangOption], "Don't build the host implementation of ESIMD functions.">,
3649-
BothFlags<[HelpHidden], [ClangOption, CLOption, DXCOption, CC1Option], "">>;
3644+
def fno_sycl_esimd_build_host_code : Flag<["-"], "fno-sycl-esimd-build-host-code">,
3645+
Visibility<[ClangOption, CLOption, DXCOption, CC1Option]>, Flags<[HelpHidden]>,
3646+
HelpText<"Don't build the host implementation of ESIMD functions.">;
36503647
def fsycl_targets_EQ : CommaJoined<["-"], "fsycl-targets=">, Flags<[NoXarchOption]>,
36513648
Visibility<[ClangOption, CLOption, DXCOption, CC1Option]>,
36523649
HelpText<"Specify comma-separated list of triples SYCL offloading targets to be supported">;

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5436,8 +5436,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
54365436
else {
54375437
for (auto &Macro : D.getSYCLTargetMacroArgs())
54385438
CmdArgs.push_back(Args.MakeArgString(Macro));
5439-
if (!Args.hasFlag(options::OPT_fsycl_esimd_build_host_code,
5440-
options::OPT_fno_sycl_esimd_build_host_code, true))
5439+
if (Args.hasArg(options::OPT_fno_sycl_esimd_build_host_code))
54415440
CmdArgs.push_back("-fno-sycl-esimd-build-host-code");
54425441
}
54435442
if (Args.hasFlag(options::OPT_fsycl_esimd_force_stateless_mem,

0 commit comments

Comments
 (0)