[SYCL] Add tests for MSVC CRT logic

Signed-off-by: Alexander Batashev <[email protected]>

Author: Alexander Batashev

clang/test/Driver/sycl-offload.c

@@ -500,6 +500,12 @@
 // CHECK-LINK-SYCL: "{{.*}}link{{(.exe)?}}"
 // CHECK-LINK-SYCL: "-defaultlib:sycl.lib"
 
+/// Check sycld.lib is chosen with /MDd and /MTd
+// RUN:  %clang_cl -fsycl /MDd %s -o %t -### 2>&1 | FileCheck -check-prefix=CHECK-LINK-SYCL-DEBUG %s
+// RUN:  %clang_cl -fsycl /MTd %s -o %t -### 2>&1 | FileCheck -check-prefix=CHECK-LINK-SYCL-DEBUG %s
+// CHECK-LINK-SYCL-DEBUG: "{{.*}}link{{(.exe)?}}"
+// CHECK-LINK-SYCL-DEBUG: "-defaultlib:sycld.lib"
+
 /// ###########################################################################
 
 /// test behaviors of -foffload-static-lib=<lib>

sycl/doc/GetStartedWithSYCLCompiler.md

@@ -362,6 +362,7 @@ int main() {
   translation units.
 - SYCL host device is not fully supported.
 - SYCL works only with OpenCL implementations supporting out-of-order queues.
+- On Windows linking SYCL applications with `/MTd` flag is known to cause crashes.
 
 # Find More
 

sycl/test/CMakeLists.txt

@@ -3,6 +3,7 @@ set(LLVM_BUILD_BINARY_DIRS "${LLVM_BINARY_DIR}/bin/")
 set(LLVM_TOOLS_DIR "${LLVM_BINARY_DIR}/bin/")
 set(CLANG_IN_BUILD "${LLVM_BINARY_DIR}/bin/clang")
 set(CLANGXX_IN_BUILD "${LLVM_BINARY_DIR}/bin/clang++")
+set(CLANGCL_IN_BUILD "${LLVM_BINARY_DIR}/bin/clang-cl")
 
 get_target_property(SYCL_BINARY_DIR sycl-toolchain BINARY_DIR)
 get_target_property(SYCL_SOURCE_DIR sycl-toolchain SOURCE_DIR)

sycl/test/lit.cfg.py

@@ -58,6 +58,7 @@
 
 config.substitutions.append( ('%clang_cc1', ' ' + config.clang + ' -cc1 ') )
 config.substitutions.append( ('%clangxx', ' ' + config.clangxx + ' -I'+config.opencl_include ) )
+config.substitutions.append( ('%clang_cl', ' ' + config.clang_cl + ' /I '+config.opencl_include ) )
 config.substitutions.append( ('%clang', ' ' + config.clang + ' -I'+config.opencl_include ) )
 config.substitutions.append( ('%llvm_build_libs_dir',  config.llvm_build_libs_dir ) )
 config.substitutions.append( ('%opencl_include',  config.opencl_include ) )

sycl/test/lit.site.cfg.py.in

@@ -4,6 +4,7 @@ import sys
 
 config.clang = "@CLANG_IN_BUILD@"
 config.clangxx = "@CLANGXX_IN_BUILD@"
+config.clang_cl = "@CLANGCL_IN_BUILD@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
 config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.llvm_build_libs_dir = "@LLVM_BUILD_LIBRARY_DIRS@"

sycl/test/regression/msvc_crt.cpp

@@ -0,0 +1,46 @@
+// RUN: %clang_cl -fsycl /MD -o %t1.exe %s
+// RUN: %CPU_RUN_PLACEHOLDER %t1.exe
+// RUN: %clang_cl -fsycl /MDd -o %t2.exe %s
+// RUN: %CPU_RUN_PLACEHOLDER %t2.exe
+// RUN: %clang_cl -fsycl /MT -o %t3.exe %s
+// RUN: %CPU_RUN_PLACEHOLDER %t3.exe
+// REQUIRES: system-windows
+//==-------------- msvc_crt.cpp - SYCL MSVC CRT test -----------------------==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// MSVC provides two different incompatible variants of CRT: debug and release.
+// This test checks if clang driver is able to handle this properly.
+
+#include <CL/sycl.hpp>
+
+using namespace cl::sycl;
+
+int main() {
+  int data[] = {0, 0, 0};
+
+  {
+    buffer<int, 1> b(data, range<1>(3), {property::buffer::use_host_ptr()});
+    queue q;
+    q.submit([&](handler &cgh) {
+      auto B = b.get_access<access::mode::write>(cgh);
+      cgh.parallel_for<class test>(range<1>(3), [=](id<1> idx) {
+        B[idx] = 1;
+      });
+    });
+  }
+
+  bool isSuccess = true;
+
+  for (int i = 0; i < 3; i++)
+    if (data[i] != 1) isSuccess = false;
+
+  if (!isSuccess)
+    return -1;
+
+  return 0;
+}