Skip to content

Commit d890d17

Browse files
committed
Address PR feedback and add note to old proposal
Signed-off-by: Lukas Sommer <[email protected]>
1 parent d490cf1 commit d890d17

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

sycl/doc/extensions/experimental/sycl_ext_codeplay_kernel_fusion.asciidoc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,16 @@ or may be in a preliminary state. The specification itself may also change in
4848
incompatible ways before it is finalized. *Shipping software products should
4949
not rely on APIs defined in this specification.*
5050

51+
[NOTE]
52+
====
53+
There is a link:../proposed/sycl_ext_oneapi_graph_fusion.asciidoc[follow-up
54+
proposal] for fusion based on the SYCL graph API. That proposal continues some
55+
of the ideas presented in this proposal, but uses the more versatile SYCL graphs
56+
API to define the sequence of kernels to execute.
57+
58+
Once accepted and implemented, the new proposal will supersede this proposal.
59+
====
60+
5161
[NOTE]
5262
====
5363
This is an experimental extension for the SYCL specification.

sycl/doc/extensions/proposed/sycl_ext_oneapi_graph_fusion.asciidoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ sycl::ext::oneapi::experimental::property::command_graph::perform_fusion
125125
```
126126

127127
The property is not prescriptive. Implementations are free to not perform fusion
128-
if it is not possible (see below section <<_limitations>>), fusion is not
128+
if it is not possible (see below section <<limitations, Limitations>>), fusion is not
129129
supported by the implementation, or the implementation decides not to perform
130130
fusion for other reasons. It is not an error if an implementation does not
131131
perform fusion even though the property is passed.
@@ -155,7 +155,7 @@ property is also part of the `property_list` of the same invocation of
155155

156156
The following property can be passed to three different APIs, namely:
157157

158-
* The `accessor` constructor, giving a more granular control
158+
* The `accessor` constructor, giving a more granular control.
159159
* The `buffer` constructor, in which case all the `accessors` derived from
160160
this buffer will inherit this property (unless overridden).
161161
* The `property_list` parameter of `sycl::malloc_device()`,
@@ -192,7 +192,7 @@ implementation-specified mechanism, but are not required to do so.
192192

193193
The following property can be passed to three different APIs, namely:
194194

195-
* The `accessor` constructor, giving a more granular control
195+
* The `accessor` constructor, giving a more granular control.
196196
* The `buffer` constructor, in which case all the `accessors` derived from
197197
this buffer will inherit this property (unless overridden).
198198
* The `property_list` parameter of `sycl::malloc_device()`,

0 commit comments

Comments
 (0)