Skip to content

Commit d96ecbe

Browse files
committed
[SYCL][NFC] Remove work-arounds for C++11
C++14 is required after #3053 Thus some of C++11 workarounds in the code became unnecessary. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
1 parent 4fed824 commit d96ecbe

File tree

4 files changed

+5
-42
lines changed

4 files changed

+5
-42
lines changed

sycl/include/CL/sycl/ONEAPI/atomic_enums.hpp

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ __SYCL_INLINE_CONSTEXPR memory_scope memory_scope_system = memory_scope::system;
6060

6161
#ifndef __SYCL_DEVICE_ONLY__
6262
namespace detail {
63-
// Cannot use switch statement in constexpr before C++14
64-
// Nested ternary conditions in else branch required for C++11
65-
#if __cplusplus >= 201402L
63+
6664
static inline constexpr std::memory_order
6765
getStdMemoryOrder(::cl::sycl::ONEAPI::memory_order order) {
6866
switch (order) {
@@ -80,22 +78,7 @@ getStdMemoryOrder(::cl::sycl::ONEAPI::memory_order order) {
8078
return std::memory_order_seq_cst;
8179
}
8280
}
83-
#else
84-
static inline constexpr std::memory_order
85-
getStdMemoryOrder(::cl::sycl::ONEAPI::memory_order order) {
86-
return (order == memory_order::relaxed)
87-
? std::memory_order_relaxed
88-
: (order == memory_order::__consume_unsupported)
89-
? std::memory_order_consume
90-
: (order == memory_order::acquire)
91-
? std::memory_order_acquire
92-
: (order == memory_order::release)
93-
? std::memory_order_release
94-
: (order == memory_order::acq_rel)
95-
? std::memory_order_acq_rel
96-
: std::memory_order_seq_cst;
97-
}
98-
#endif // __cplusplus
81+
9982
} // namespace detail
10083
#endif // __SYCL_DEVICE_ONLY__
10184

sycl/include/CL/sycl/ONEAPI/atomic_ref.hpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ template <> struct memory_order_traits<memory_order::seq_cst> {
6969
static constexpr memory_order write_order = memory_order::seq_cst;
7070
};
7171

72-
// Cannot use switch statement in constexpr before C++14
73-
// Nested ternary conditions in else branch required for C++11
74-
#if __cplusplus >= 201402L
7572
inline constexpr memory_order getLoadOrder(memory_order order) {
7673
switch (order) {
7774
case memory_order_relaxed:
@@ -87,14 +84,6 @@ inline constexpr memory_order getLoadOrder(memory_order order) {
8784
return memory_order_seq_cst;
8885
}
8986
}
90-
#else
91-
inline constexpr memory_order getLoadOrder(memory_order order) {
92-
return (order == memory_order_relaxed)
93-
? memory_order_relaxed
94-
: (order == memory_order_seq_cst) ? memory_order_seq_cst
95-
: memory_order_acquire;
96-
}
97-
#endif
9887

9988
template <typename T, typename = void> struct bit_equal;
10089

sycl/include/CL/sycl/ONEAPI/functional.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ template <typename T = void> struct minimum {
1919
}
2020
};
2121

22-
#if __cplusplus >= 201402L
2322
template <> struct minimum<void> {
2423
struct is_transparent {};
2524
template <typename T, typename U>
@@ -30,15 +29,13 @@ template <> struct minimum<void> {
3029
: std::forward<U>(rhs);
3130
}
3231
};
33-
#endif
3432

3533
template <typename T = void> struct maximum {
3634
T operator()(const T &lhs, const T &rhs) const {
3735
return std::greater<T>()(lhs, rhs) ? lhs : rhs;
3836
}
3937
};
4038

41-
#if __cplusplus >= 201402L
4239
template <> struct maximum<void> {
4340
struct is_transparent {};
4441
template <typename T, typename U>
@@ -50,7 +47,6 @@ template <> struct maximum<void> {
5047
: std::forward<U>(rhs);
5148
}
5249
};
53-
#endif
5450

5551
template <typename T = void> using plus = std::plus<T>;
5652
template <typename T = void> using multiplies = std::multiplies<T>;

sycl/include/CL/sycl/half_type.hpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@
2626
#else
2727
#define __SYCL_CONSTEXPR_ON_DEVICE
2828
#endif
29-
#if __cplusplus >= 201402L
30-
#define _CPP14_CONSTEXPR constexpr
31-
#else
32-
#define _CPP14_CONSTEXPR
33-
#endif
3429

3530
__SYCL_INLINE_NAMESPACE(cl) {
3631
namespace sycl {
@@ -80,7 +75,7 @@ class __SYCL_EXPORT half {
8075
}
8176

8277
// Operator neg
83-
_CPP14_CONSTEXPR half &operator-() {
78+
constexpr half &operator-() {
8479
Buf ^= 0x8000;
8580
return *this;
8681
}
@@ -207,11 +202,11 @@ class half {
207202
operator--();
208203
return ret;
209204
}
210-
_CPP14_CONSTEXPR half &operator-() {
205+
constexpr half &operator-() {
211206
Data = -Data;
212207
return *this;
213208
}
214-
_CPP14_CONSTEXPR half operator-() const {
209+
constexpr half operator-() const {
215210
half r = *this;
216211
return -r;
217212
}

0 commit comments

Comments
 (0)