Skip to content

Commit da0f66b

Browse files
authored
[SYCL]Deletion of workaround for wrong mangling of s_upsample (#1053)
We had issue with wrong mangling of s_upsample. I fixed it a long time ago, so we can delete workaround now. Signed-off-by: Ilya Mashkov <[email protected]>
1 parent 12577b5 commit da0f66b

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

sycl/include/CL/sycl/builtins.hpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -851,10 +851,6 @@ detail::enable_if_t<detail::is_ugeninteger<T>::value, T> sub_sat(T x,
851851
return __sycl_std::__invoke_u_sub_sat<T>(x, y);
852852
}
853853

854-
// TODO delete when Intel CPU OpenCL runtime will be fixed
855-
// OpExtInst ... s_upsample -> _Z8upsampleij (now _Z8upsampleii)
856-
#define __invoke_s_upsample __invoke_u_upsample
857-
858854
// ugeninteger16bit upsample (ugeninteger8bit hi, ugeninteger8bit lo)
859855
template <typename T>
860856
detail::enable_if_t<detail::is_ugeninteger8bit<T>::value,
@@ -909,8 +905,6 @@ upsample(T hi, T2 lo) __NOEXC {
909905
return __sycl_std::__invoke_s_upsample<detail::make_larger_t<T>>(hi, lo);
910906
}
911907

912-
#undef __invoke_s_upsample
913-
914908
// geninteger popcount (geninteger x)
915909
template <typename T>
916910
detail::enable_if_t<detail::is_geninteger<T>::value, T> popcount(T x) __NOEXC {

sycl/source/detail/builtins_integer.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -720,10 +720,6 @@ MAKE_1V_2V(u_upsample, s::cl_ushort, s::cl_uchar, s::cl_uchar)
720720
MAKE_1V_2V(u_upsample, s::cl_uint, s::cl_ushort, s::cl_ushort)
721721
MAKE_1V_2V(u_upsample, s::cl_ulong, s::cl_uint, s::cl_uint)
722722

723-
// TODO delete when Intel CPU OpenCL runtime will be fixed
724-
// ExtInst ... s_upsample -> _Z8upsampleij (now _Z8upsampleii)
725-
#define s_upsample u_upsample
726-
727723
s::cl_short s_upsample(s::cl_char x, s::cl_uchar y) __NOEXC {
728724
return __upsample(x, y);
729725
}
@@ -737,8 +733,6 @@ MAKE_1V_2V(s_upsample, s::cl_short, s::cl_char, s::cl_uchar)
737733
MAKE_1V_2V(s_upsample, s::cl_int, s::cl_short, s::cl_ushort)
738734
MAKE_1V_2V(s_upsample, s::cl_long, s::cl_int, s::cl_uint)
739735

740-
#undef s_upsample
741-
742736
// popcount
743737
s::cl_uchar popcount(s::cl_uchar x) __NOEXC { return __popcount(x); }
744738
s::cl_ushort popcount(s::cl_ushort x) __NOEXC { return __popcount(x); }

0 commit comments

Comments
 (0)