Skip to content

Commit df3552c

Browse files
v-klochkovbader
authored andcommitted
[SYCL][NFC] Fix Windows warnings, sync usage of class/struct with new SYCL SPEC
Signed-off-by: Klochkov <[email protected]>
1 parent c016c56 commit df3552c

File tree

9 files changed

+23
-22
lines changed

9 files changed

+23
-22
lines changed

sycl/include/CL/sycl/detail/array.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace cl {
1616
namespace sycl {
17-
template <int dimensions> struct id;
17+
template <int dimensions> class id;
1818
template <int dimensions> class range;
1919
namespace detail {
2020

sycl/include/CL/sycl/detail/helpers.hpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ namespace cl {
2222
namespace sycl {
2323
class context;
2424
class event;
25-
template <int dimensions, bool with_offset> struct item;
25+
template <int dimensions, bool with_offset> class item;
2626
template <int dimensions> class group;
2727
template <int dimensions> class range;
28-
template <int dimensions> struct id;
28+
template <int dimensions> class id;
2929
template <int dimensions> class nd_item;
3030
enum class memory_order;
3131
template <int dimensions> class h_item;
@@ -40,7 +40,8 @@ getOrWaitEvents(std::vector<cl::sycl::event> DepEvents,
4040

4141
void waitEvents(std::vector<cl::sycl::event> DepEvents);
4242

43-
struct Builder {
43+
class Builder {
44+
public:
4445
Builder() = delete;
4546
template <int dimensions>
4647
static group<dimensions> createGroup(const cl::sycl::range<dimensions> &G,

sycl/include/CL/sycl/group.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
namespace cl {
2525
namespace sycl {
2626
namespace detail {
27-
struct Builder;
27+
class Builder;
2828

2929
// Implements a barrier accross work items within a work group.
3030
static inline void workGroupBarrier() {
@@ -290,7 +290,7 @@ template <int dimensions = 1> class group {
290290
}
291291

292292
protected:
293-
friend struct detail::Builder;
293+
friend class detail::Builder;
294294
group(const range<dimensions> &G, const range<dimensions> &L,
295295
const id<dimensions> &I)
296296
: globalRange(G), localRange(L), index(I) {}

sycl/include/CL/sycl/id.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace cl {
1616
namespace sycl {
1717
template <int dimensions> class range;
1818
template <int dimensions, bool with_offset> class item;
19-
template <int dimensions = 1> struct id : public detail::array<dimensions> {
19+
template <int dimensions = 1> class id : public detail::array<dimensions> {
2020
private:
2121
using base = detail::array<dimensions>;
2222
static_assert(dimensions >= 1 && dimensions <= 3,

sycl/include/CL/sycl/intel/sub_group.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ struct sub_group {
343343
}
344344

345345
protected:
346-
template <int dimensions> friend struct cl::sycl::nd_item;
346+
template <int dimensions> friend class cl::sycl::nd_item;
347347
sub_group() = default;
348348
};
349349
} // namespace intel

sycl/include/CL/sycl/intel/sub_group_host.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ struct sub_group {
137137
}
138138

139139
protected:
140-
template <int dimensions> friend struct cl::sycl::nd_item;
140+
template <int dimensions> friend class cl::sycl::nd_item;
141141
sub_group() {
142142
throw runtime_error("Subgroups are not supported on host device. ");
143143
}

sycl/include/CL/sycl/item.hpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616
namespace cl {
1717
namespace sycl {
1818
namespace detail {
19-
struct Builder;
19+
class Builder;
2020
}
21-
template <int dimensions> struct id;
21+
template <int dimensions> class id;
2222
template <int dimensions> class range;
2323
template <int dimensions> class h_item;
2424

25-
template <int dimensions = 1, bool with_offset = true> struct item {
26-
25+
template <int dimensions = 1, bool with_offset = true> class item {
26+
public:
2727
item() = delete;
2828

2929
id<dimensions> get_id() const { return index; }
@@ -86,10 +86,10 @@ template <int dimensions = 1, bool with_offset = true> struct item {
8686

8787
protected:
8888
// For call constructor inside conversion operator
89-
friend struct item<dimensions, false>;
90-
friend struct item<dimensions, true>;
91-
friend struct h_item<dimensions>;
92-
friend struct detail::Builder;
89+
friend class item<dimensions, false>;
90+
friend class item<dimensions, true>;
91+
friend class h_item<dimensions>;
92+
friend class detail::Builder;
9393

9494
template <size_t W = with_offset>
9595
item(typename std::enable_if<(W == true), const range<dimensions>>::type &R,

sycl/include/CL/sycl/nd_item.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
namespace cl {
2525
namespace sycl {
2626
namespace detail {
27-
struct Builder;
27+
class Builder;
2828
}
29-
template <int dimensions = 1> struct nd_item {
30-
29+
template <int dimensions = 1> class nd_item {
30+
public:
3131
nd_item() = delete;
3232

3333
id<dimensions> get_global_id() const { return globalItem.get_id(); }
@@ -154,7 +154,7 @@ template <int dimensions = 1> struct nd_item {
154154
}
155155

156156
protected:
157-
friend struct detail::Builder;
157+
friend class detail::Builder;
158158
nd_item(const item<dimensions, true> &GL, const item<dimensions, false> &L,
159159
const group<dimensions> &GR)
160160
: globalItem(GL), localItem(L), Group(GR) {}

sycl/include/CL/sycl/range.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
namespace cl {
1515
namespace sycl {
16-
template <int dimensions> struct id;
16+
template <int dimensions> class id;
1717
template <int dimensions = 1>
1818
class range : public detail::array<dimensions> {
1919
static_assert(dimensions >= 1 && dimensions <= 3,

0 commit comments

Comments
 (0)