address feedback

Signed-off-by: Sarnie, Nick <[email protected]>

Author: sarnex

sycl/include/std/experimental/simd.hpp

@@ -1682,12 +1682,14 @@ class simd_mask {
 
   // implicit type conversion constructor
 #ifdef ENABLE_SYCL_EXT_ONEAPI_INVOKE_SIMD
-  // TODO inefficient, use this's and __v's storage directly
+  template <class _Up>
+  simd_mask(const simd_mask<_Up, simd_abi::fixed_size<size()>>& __v) noexcept {
+    copyElements(__v);
+  }
+
   template <class _Up>
   simd_mask(const simd_mask<_Up, abi_type>& __v) noexcept {
-    for (size_t __i = 0; __i < size(); __i++) {
-      (*this)[__i] = static_cast<element_type>(__v[__i]);
-    }
+    copyElements(__v);
   }
 #else
   template <class _Up>
@@ -1735,6 +1737,14 @@ class simd_mask {
 #ifdef ENABLE_SYCL_EXT_ONEAPI_INVOKE_SIMD
 private:
   __simd_storage<element_type, _Abi> __s_;
+
+  // TODO inefficient, use this's and __v's storage directly
+  template <class _Up, class _UAbi>
+  inline void copyElements(const simd_mask<_Up, _UAbi> & __v) noexcept {
+    for (size_t __i = 0; __i < size(); __i++) {
+      (*this)[__i] = static_cast<element_type>(__v[__i]);
+    }
+  }
 #endif // ENABLE_SYCL_EXT_ONEAPI_INVOKE_SIMD
 };