Skip to content

Commit e47b588

Browse files
author
Andy Kaylor
authored
Fix fp-accuracy build problems and minor cosmetic issues (#8200)
This change fixes a clang-specific build problem and a few minor cosmetic issues with the fp-accuracy intrinsic patch.
1 parent b13561c commit e47b588

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

llvm/docs/LangRef.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23134,7 +23134,7 @@ intrinsic has any callsite attributes begining with "fpbuiltin-" that the code
2313423134
performing the transformation does not recognize.
2313523135

2313623136
Unless otherwise specified using callsite attributes, the fpbuiltin intrinsics
23137-
do not set ``errno`` or and are not guaranteed to maintain correct
23137+
do not set ``errno`` and are not guaranteed to maintain correct
2313823138
floating-point exception state.
2313923139

2314023140
All fpbuiltin intrinsics are overloaded intrinsics which may operate on any

llvm/include/llvm/Analysis/TargetLibraryInfo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class Function;
2424
class Module;
2525
class Triple;
2626

27-
/// Describes a possible implementation of a floating point builtin operation
27+
/// Describes a possible implementation of a floating point builtin operation.
2828
struct AltMathDesc {
2929
Intrinsic::ID IntrinID;
3030
Type::TypeID BaseFPType;
@@ -79,7 +79,7 @@ class TargetLibraryInfoImpl {
7979
}
8080

8181
/// Alternate math library functions - sorted by intrinsic ID, then type,
82-
/// then vector size, then accuracy
82+
/// then vector size, then accuracy
8383
std::vector<AltMathDesc> AltMathFuncDescs;
8484

8585
/// Vectorization descriptors - sorted by ScalarFnName.

llvm/lib/CodeGen/FPBuiltinFnSelection.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ static bool selectFnForFPBuiltinCalls(const TargetLibraryInfo &TLI,
7474
dbgs() << BuiltinCall.getRequiredAccuracy().value() << "\n";
7575
});
7676

77-
StringSet RecognizedAttrs = {FPBuiltinIntrinsic::FPBUILTIN_MAX_ERROR};
77+
StringSet<> RecognizedAttrs = {FPBuiltinIntrinsic::FPBUILTIN_MAX_ERROR};
7878
if (BuiltinCall.hasUnrecognizedFPAttrs(RecognizedAttrs)) {
7979
report_fatal_error(
8080
Twine(BuiltinCall.getCalledFunction()->getName()) +
@@ -142,7 +142,7 @@ class FPBuiltinFnSelectionLegacyPass : public FunctionPass {
142142
return runImpl(*TLI, F);
143143
}
144144

145-
void getAnalysisUsage(AnalysisUsage &AU) const {
145+
void getAnalysisUsage(AnalysisUsage &AU) const override {
146146
AU.setPreservesCFG();
147147
AU.addRequired<TargetLibraryInfoWrapperPass>();
148148
AU.addPreserved<TargetLibraryInfoWrapperPass>();

0 commit comments

Comments
 (0)