@@ -81,6 +81,15 @@ approved by an Intel representative.
81
81
- A new approval is needed if the PR was updated (e.g. during code review).
82
82
- Once the PR is approved and all checks have passed, the pull request is
83
83
ready for merge.
84
+ - Sometimes unrelated fails can be observed in the PR. It' s author
85
+ responsibility to find/guess the reason of these fails and post a comment in
86
+ the PR with:
87
+ - possible reason of fails, ideally with a link to the PR, which caused fails
88
+ - link to other PR(s), which expected to fix fails
89
+ - person who is currently looking into fails
90
+ - link to existing open issue
91
+ - if author cannot identify any of these, the minimal action expected is to
92
+ open a new [issue](/../../issues)
84
93
85
94
### Merge
86
95
@@ -89,7 +98,8 @@ and merge] and using PR description as the commit message, replacing all
89
98
individual comments made per commit. Authors of the change must ensure PR
90
99
description is up to date at the merge stage, as sometimes comments addressed
91
100
during code reviews can invalidate original PR description. Feel free to ping
92
- @intel/llvm-gatekeepers if your PR is green and can be merged.
101
+ @intel/llvm-gatekeepers if your PR is green and can be merged. Note that
102
+ gatekeepers will require explanation for any failures observed.
93
103
94
104
Pulldown from LLVM upstream is done through merge commits to preserve hashes of
95
105
the original commits pulled from the LLVM community repository.
0 commit comments