Signed-off-by: kbobrovs <[email protected]>

Fix test failures:
- fix vertical stride in replicate
- allow unary logical negation for simd with integer element type
- use data() to access M_data in non-constructors

Author: kbobrovs

sycl/include/sycl/ext/intel/experimental/esimd/detail/simd_obj_impl.hpp

@@ -534,9 +534,17 @@ template <typename Ty, int N, class Derived, class SFINAE> class simd_obj_impl {
   /// @} // Memory operations
 
   /// Bitwise inversion, available in all subclasses.
-  template <class T1 = Ty> Derived operator~() {
-    static_assert(std::is_integral_v<T1>, "'~' applies only to integral types");
-    return Derived(~M_data);
+  template <class T1 = Ty, class = std::enable_if_t<std::is_integral_v<T1>>>
+  Derived operator~() {
+    return Derived(~data());
+  }
+
+  /// Unary logical negation operator, available in all subclasses.
+  template <class T1 = Ty, class = std::enable_if_t<std::is_integral_v<T1>>>
+  simd_mask<N> operator!() {
+    using MaskVecT = typename simd_mask<N>::vector_type;
+    auto R = data() == vector_type(0);
+    return simd_mask<N>{__builtin_convertvector(R, MaskVecT) & MaskVecT(1)};
   }
 
 #define __ESIMD_DEF_SIMD_OBJ_IMPL_OPASSIGN(BINOP, OPASSIGN, COND)              \

sycl/include/sycl/ext/intel/experimental/esimd/detail/simd_view_impl.hpp

@@ -277,11 +277,14 @@ template <typename BaseTy, typename RegionTy> class simd_view_impl {
 
 #undef __ESIMD_DEF_UNARY_OP
 
-  template <class T = element_type, class SimdT = BaseTy,
-            class = std::enable_if_t<is_simd_mask_type_v<SimdT>>>
+  /// Unary logical negeation operator. Applies only to integer element types.
+  template <class T = element_type,
+            class = std::enable_if_t<std::is_integral_v<T>>>
   auto operator!() {
+    using MaskVecT = typename simd_mask_type<length>::vector_type;
     auto V = read().data() == 0;
-    return get_simd_t<element_type, length>(V);
+    return simd_mask_type<length>{__builtin_convertvector(V, MaskVecT) &
+                                  MaskVecT(1)};
   }
 
   /// @{
@@ -290,9 +293,12 @@ template <typename BaseTy, typename RegionTy> class simd_view_impl {
     return write(Other.read());
   }
 
+  Derived &operator=(const Derived &Other) { return write(Other.read()); }
+
   Derived &operator=(const value_type &Val) { return write(Val); }
 
   /// Move assignment operator.
+  Derived &operator=(Derived &&Other) { return write(Other.read()); }
   simd_view_impl &operator=(simd_view_impl &&Other) {
     return write(Other.read());
   }
@@ -406,7 +412,7 @@ template <typename BaseTy, typename RegionTy> class simd_view_impl {
   /// \return replicated simd instance.
   template <int Rep, int W>
   get_simd_t<element_type, Rep * W> replicate(uint16_t OffsetX) {
-    return replicate<Rep, 1, W>(0, OffsetX);
+    return replicate<Rep, 0, W>(0, OffsetX);
   }
 
   /// \tparam Rep is number of times region has to be replicated.
@@ -417,7 +423,7 @@ template <typename BaseTy, typename RegionTy> class simd_view_impl {
   template <int Rep, int W>
   get_simd_t<element_type, Rep * W> replicate(uint16_t OffsetY,
                                               uint16_t OffsetX) {
-    return replicate<Rep, 1, W>(OffsetY, OffsetX);
+    return replicate<Rep, 0, W>(OffsetY, OffsetX);
   }
 
   /// \tparam Rep is number of times region has to be replicated.

sycl/include/sycl/ext/intel/experimental/esimd/simd.hpp

@@ -200,13 +200,6 @@ class simd_mask_impl
   operator bool() {
     return base_type::data()[0] != 0;
   }
-
-  /// Unary logical negation operator.
-  simd_mask_impl operator!() {
-    auto R = base_type::data() == vector_type(0);
-    return simd_mask_impl{__builtin_convertvector(R, vector_type) &
-                          vector_type(1)};
-  }
 };
 
 } // namespace detail