Skip to content

Commit eb6d2d7

Browse files
committed
Add TODO comment for a future improvement.
1 parent e1511a7 commit eb6d2d7

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

llvm/lib/SYCLLowerIR/LowerWGScope.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,19 @@
6565
// (1) - materialization of a PFWI object
6666
// (2) - "fixup" of the private variable address.
6767
//
68+
// TODO: add support for the case when there are other functions between
69+
// parallel_for_work_group and parallel_for_work_item in the call stack.
70+
// For example:
71+
//
72+
// void foo(sycl::group<1> group, ...) {
73+
// group.parallel_for_work_item(range<1>(), [&](h_item<1> i) { ... });
74+
// }
75+
// ...
76+
// cgh.parallel_for_work_group<class kernel>(
77+
// range<1>(...), range<1>(...), [=](group<1> g) {
78+
// foo(g, ...);
79+
// });
80+
//
6881
// TODO The approach employed by this pass generates lots of barriers and data
6982
// copying between private and local memory, which might not be efficient. There
7083
// are optimization opportunities listed below. Also other approaches can be

0 commit comments

Comments
 (0)