Skip to content

Commit ebb8d44

Browse files
author
Michael Kinsner
committed
Incorporate feedback
Signed-off-by: Michael Kinsner <[email protected]>
1 parent c46d59f commit ebb8d44

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

sycl/doc/extensions/RelaxStdLayout/SYCL_INTEL_relax_standard_layout.asciidoc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Because the interfaces defined by this specification are not final and are subje
4848
== Version
4949

5050
Built On: {docdate} +
51-
Revision: 1
51+
Revision: 2
5252

5353
== Contact
5454
Michael Kinsner, Intel (michael 'dot' kinsner 'at' intel 'dot' com)
@@ -59,7 +59,7 @@ This extension is written against the SYCL 1.2.1 specification, Revision 6.
5959

6060
== Overview
6161

62-
SYCL 1.2.1 required data stored into a buffer or passed as a kernel argument to be standard layout. This is in addition to the data also being trivially copyable. This extension relaxes the standard layout requirement while leaving the trivially copyable requirement intact.
62+
SYCL 1.2.1 requires data stored into a buffer or passed as a kernel argument to be standard layout. This is in addition to the data also being trivially copyable. This extension relaxes the standard layout requirement while leaving the trivially copyable requirement intact.
6363

6464
Standard layout does not guarantee ABI compatibility across devices or between a device and the host, but can help. To avoid introducing incompatible data layouts, this extension also requires device compilers to validate that their layout of data is compatible with that used by the host. There are multiple implementation approaches that can achieve this, although they are beyond the scope of this extension which describes the behavior only.
6565

@@ -73,7 +73,7 @@ Sharing data structures between host and device code imposes certain restriction
7373

7474
==== To:
7575

76-
Sharing data structures between host and device code imposes certain restrictions, such as use of only user defined classes that are {cpp}11 trivially copyable classes for the data structures, classes that are {cpp}11 trivially copyable classes for the data structures, and in general, no pointers initialized for the host can be used on the device.
76+
Sharing data structures between host and device code imposes certain restrictions, such as use of only user defined classes that are {cpp}11 trivially copyable classes for the data structures, and in general, no pointers initialized for the host can be used on the device.
7777

7878
=== Modify Sentence in Section 4.8.5 (SYCL function for invoking kernels, +set_arg+ description)
7979

@@ -148,6 +148,7 @@ None.
148148
|========================================
149149
|Rev|Date|Author|Changes
150150
|1|2020-03-17|Michael Kinsner|*Initial public working draft*
151+
|2|2020-03-24|Michael Kinsner|Remove repeated sentence and fix typo
151152
|========================================
152153
153154
//************************************************************************

0 commit comments

Comments
 (0)