Skip to content

Commit edaf76b

Browse files
committed
fix comments
Signed-off-by: Sidorov, Dmitry <[email protected]>
1 parent 66ec50c commit edaf76b

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

clang/lib/Driver/ToolChains/SYCL.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1935,7 +1935,6 @@ void SYCLToolChain::AddImpliedTargetArgs(const llvm::Triple &Triple,
19351935
Triple.isSPIROrSPIRV() && Triple.getSubArch() == llvm::Triple::NoSubArch;
19361936
if (IsGen && Args.hasArg(options::OPT_fsycl_fp64_conv_emu))
19371937
BeArgs.push_back("-ze-fp64-gen-conv-emu");
1938-
19391938
if (Arg *A = Args.getLastArg(options::OPT_g_Group, options::OPT__SLASH_Z7))
19401939
if (!A->getOption().matches(options::OPT_g0))
19411940
BeArgs.push_back("-g");

llvm/include/llvm/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.h

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// Remove llvm.fpbuiltin.[sqrt/fdiv] intrinsics to ensure backward compatibility
9-
// with the old drivers (that don't support SPV_INTEL_fp_max_error extension)
10-
// in case if they are used with standart for OpenCL max-error (e.g [3.0/2.5]
11-
// ULP and there are no other llvm.fpbuiltin.* intrinsic functions, fdiv
12-
// instructions or @sqrt builtins/intrinsics in the module.
8+
// Remove llvm.fpbuiltin.[sqrt/fdiv] intrinsics to ensure compatibility with the
9+
// old drivers (that don't support SPV_INTEL_fp_max_error extension).
10+
// The intrinsic functions are removed in case if they are used with standard
11+
// for OpenCL max-error (e.g [3.0/2.5] ULP) and there are no:
12+
// - other llvm.fpbuiltin.* intrinsic functions;
13+
// - fdiv instructions
14+
// - @sqrt builtins (both C and C++-styles)/llvm intrinsic in the module.
1315
//===----------------------------------------------------------------------===//
14-
//
1516
#ifndef LLVM_SYCL_SQRT_FDIV_MAX_ERROR_CLEAN_UP_H
1617
#define LLVM_SYCL_SQRT_FDIV_MAX_ERROR_CLEAN_UP_H
1718

llvm/lib/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// Remove llvm.fpbuiltin.[sqrt/fdiv] intrinsics to ensure backward compatibility
9-
// with the old drivers (that don't support SPV_INTEL_fp_max_error extension)
10-
// in case if they are used with standart for OpenCL max-error (e.g [3.0/2.5]
11-
// ULP and there are no other llvm.fpbuiltin.* intrinsic functions, fdiv
12-
// instructions or @sqrt builtins/intrinsics in the module.
8+
// Remove llvm.fpbuiltin.[sqrt/fdiv] intrinsics to ensure compatibility with the
9+
// old drivers (that don't support SPV_INTEL_fp_max_error extension).
10+
// The intrinsic functions are removed in case if they are used with standard
11+
// for OpenCL max-error (e.g [3.0/2.5] ULP) and there are no:
12+
// - other llvm.fpbuiltin.* intrinsic functions;
13+
// - fdiv instructions
14+
// - @sqrt builtins (both C and C++-styles)/llvm intrinsic in the module.
1315
//===----------------------------------------------------------------------===//
1416

1517
#include "llvm/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.h"
@@ -74,7 +76,7 @@ SYCLSqrtFDivMaxErrorCleanUpPass::run(Module &M,
7476
}
7577
}
7678

77-
// No intrinsics at all - do an early exist
79+
// No intrinsics at all - do an early exist.
7880
if (WorkListSqrt.empty() && WorkListFDiv.empty())
7981
return PreservedAnalyses::none();
8082

0 commit comments

Comments
 (0)