Skip to content

Commit ede54b3

Browse files
authored
Merge branch 'main' into yc-test-main/0120-on-shadow-per-type
2 parents e2a894c + 57715b2 commit ede54b3

File tree

4 files changed

+85
-21
lines changed

4 files changed

+85
-21
lines changed

scripts/benchmarks/benches/compute.py

Lines changed: 56 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def setup(self):
2222
if options.sycl is None:
2323
return
2424

25-
repo_path = git_clone(self.directory, "compute-benchmarks-repo", "https://github.com/intel/compute-benchmarks.git", "d13e5b4d8dd3d28926a74ab7f67f78c10f708a01")
25+
repo_path = git_clone(self.directory, "compute-benchmarks-repo", "https://github.com/intel/compute-benchmarks.git", "578a7ac6f9bc48f6c2b408ef64a19a2ef9a216e7")
2626
build_path = create_build_path(self.directory, 'compute-benchmarks-build')
2727

2828
configure_command = [
@@ -74,6 +74,18 @@ def benchmarks(self) -> list[Benchmark]:
7474
MemcpyExecute(self, 10, 16, 1024, 10000, 0, 1, 1),
7575
MemcpyExecute(self, 4096, 1, 1024, 10, 0, 1, 0),
7676
MemcpyExecute(self, 4096, 4, 1024, 10, 0, 1, 0),
77+
GraphApiSinKernelGraphSYCL(self, 0, 10),
78+
GraphApiSinKernelGraphSYCL(self, 1, 10),
79+
GraphApiSinKernelGraphSYCL(self, 0, 100),
80+
GraphApiSinKernelGraphSYCL(self, 1, 100),
81+
# Submit
82+
GraphApiSubmitExecGraph(self, 0, 1, 10),
83+
GraphApiSubmitExecGraph(self, 1, 1, 10),
84+
GraphApiSubmitExecGraph(self, 1, 1, 100),
85+
# Exec
86+
GraphApiSubmitExecGraph(self, 0, 0, 10),
87+
GraphApiSubmitExecGraph(self, 1, 0, 10),
88+
GraphApiSubmitExecGraph(self, 1, 0, 100),
7789
]
7890

7991
if options.ur is not None:
@@ -357,3 +369,46 @@ def bin_args(self) -> list[str]:
357369
f"--SrcUSM={self.srcUSM}",
358370
f"--DstUSM={self.dstUSM}",
359371
]
372+
373+
class GraphApiSinKernelGraphSYCL(ComputeBenchmark):
374+
def __init__(self, bench, withGraphs, numKernels):
375+
self.withGraphs = withGraphs
376+
self.numKernels = numKernels
377+
super().__init__(bench, "graph_api_benchmark_sycl", "SinKernelGraph")
378+
379+
def explicit_group(self):
380+
return "SinKernelGraph"
381+
382+
def name(self):
383+
return f"graph_api_benchmark_sycl SinKernelGraph graphs:{self.withGraphs}, numKernels:{self.numKernels}"
384+
385+
def bin_args(self) -> list[str]:
386+
return [
387+
"--iterations=100",
388+
f"--numKernels={self.numKernels}",
389+
f"--withGraphs={self.withGraphs}",
390+
]
391+
392+
class GraphApiSubmitExecGraph(ComputeBenchmark):
393+
def __init__(self, bench, ioq, submit, numKernels):
394+
self.ioq = ioq
395+
self.submit = submit
396+
self.numKernels = numKernels
397+
super().__init__(bench, "graph_api_benchmark_sycl", "SubmitExecGraph")
398+
399+
def name(self):
400+
return f"graph_api_benchmark_sycl SubmitExecGraph ioq:{self.ioq}, submit:{self.submit}, numKernels:{self.numKernels}"
401+
402+
def explicit_group(self):
403+
if self.submit:
404+
return "SubmitGraph"
405+
else:
406+
return "ExecGraph"
407+
408+
def bin_args(self) -> list[str]:
409+
return [
410+
"--iterations=100",
411+
f"--measureSubmit={self.submit}",
412+
f"--ioq={self.ioq}",
413+
f"--numKernels={self.numKernels}",
414+
]

source/adapters/level_zero/image.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,7 @@ ur_result_t bindlessImagesCreateImpl(ur_context_handle_t hContext,
517517
ZE2UR_CALL(zeContextMakeImageResident,
518518
(hContext->ZeContext, hDevice->ZeDevice, ZeImage));
519519
} else if (MemAllocProperties.type == ZE_MEMORY_TYPE_DEVICE ||
520+
MemAllocProperties.type == ZE_MEMORY_TYPE_HOST ||
520521
MemAllocProperties.type == ZE_MEMORY_TYPE_SHARED) {
521522
ZeStruct<ze_image_pitched_exp_desc_t> PitchedDesc;
522523
PitchedDesc.ptr = reinterpret_cast<void *>(hImageMem);

source/loader/layers/sanitizer/asan/asan_buffer.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ struct MemBuffer {
2929

3030
// Sub-buffer constructor
3131
MemBuffer(std::shared_ptr<MemBuffer> Parent, size_t Origin, size_t Size)
32-
: Context(Parent->Context), Size(Size), SubBuffer{{Parent, Origin}} {}
32+
: Context(Parent->Context), Size(Size),
33+
SubBuffer{{std::move(Parent), Origin}} {}
3334

3435
ur_result_t getHandle(ur_device_handle_t Device, char *&Handle);
3536

test/adapters/level_zero/v2/CMakeLists.txt

Lines changed: 26 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -63,25 +63,32 @@ add_adapter_test(level_zero_memory_residency
6363
)
6464

6565
if(NOT WIN32)
66-
add_adapter_test(level_zero_deferred_kernel
67-
FIXTURE KERNELS
68-
SOURCES
69-
deferred_kernel.cpp
70-
ENVIRONMENT
71-
"UR_ADAPTERS_FORCE_LOAD=\"$<TARGET_FILE:ur_adapter_level_zero_v2>\""
72-
)
66+
if (NOT UR_DPCXX)
67+
# Tests that require kernels can't be used if we aren't generating
68+
# device binaries
69+
message(WARNING
70+
"UR_DPCXX is not defined, skipping some tests for level_zero_v2 adapter")
71+
else()
72+
add_adapter_test(level_zero_deferred_kernel
73+
FIXTURE KERNELS
74+
SOURCES
75+
deferred_kernel.cpp
76+
ENVIRONMENT
77+
"UR_ADAPTERS_FORCE_LOAD=\"$<TARGET_FILE:ur_adapter_level_zero_v2>\""
78+
)
7379

74-
set(backend level_zero)
75-
add_adapter_memcheck_test(level_zero_deferred_kernel
76-
FIXTURE KERNELS
77-
SOURCES
78-
deferred_kernel.cpp
79-
ENVIRONMENT
80-
"UR_ADAPTERS_FORCE_LOAD=\"$<TARGET_FILE:ur_adapter_level_zero_v2>\""
81-
)
80+
set(backend level_zero)
81+
add_adapter_memcheck_test(level_zero_deferred_kernel
82+
FIXTURE KERNELS
83+
SOURCES
84+
deferred_kernel.cpp
85+
ENVIRONMENT
86+
"UR_ADAPTERS_FORCE_LOAD=\"$<TARGET_FILE:ur_adapter_level_zero_v2>\""
87+
)
8288

83-
target_link_libraries(test-adapter-level_zero_deferred_kernel PRIVATE
84-
LevelZeroLoader
85-
LevelZeroLoader-Headers
86-
)
89+
target_link_libraries(test-adapter-level_zero_deferred_kernel PRIVATE
90+
LevelZeroLoader
91+
LevelZeroLoader-Headers
92+
)
93+
endif()
8794
endif()

0 commit comments

Comments
 (0)