Skip to content

Commit ee39a68

Browse files
authored
[SYCL] Fix version of OpenCL headers and ICD loader (#3247)
1 parent e1b4202 commit ee39a68

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

buildbot/dependency.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,29 +50,34 @@ def do_dependency(args):
5050
ocl_header_dir = os.path.join(args.obj_dir, "OpenCL-Headers")
5151
if not os.path.isdir(ocl_header_dir):
5252
clone_cmd = ["git", "clone", "https://github.com/KhronosGroup/OpenCL-Headers",
53-
"OpenCL-Headers", "-b", "v2020.06.16"]
53+
"OpenCL-Headers", "-b", "master"]
5454
subprocess.check_call(clone_cmd, cwd=args.obj_dir)
5555
else:
5656
fetch_cmd = ["git", "pull", "--ff", "--ff-only", "origin"]
5757
subprocess.check_call(fetch_cmd, cwd=ocl_header_dir)
5858

59-
# Workaround to unblock CI until KhronosGroup/OpenCL-ICD-Loader/pull/124
60-
# is submitted
61-
checkout_cmd = ["git", "checkout", "d1b936b72b9610626ecab8a991cec18348fba047"]
59+
# Checkout fixed version to avoid unexpected issues coming from upstream
60+
# Specific version can be uplifted as soon as such need arise
61+
checkout_cmd = ["git", "checkout", "23710f1b99186065c1768fc3098ba681adc0f253"]
6262
subprocess.check_call(checkout_cmd, cwd=ocl_header_dir)
6363

6464
# fetch and build OpenCL ICD loader
6565
icd_loader_dir = os.path.join(args.obj_dir, "OpenCL-ICD-Loader")
6666
if not os.path.isdir(icd_loader_dir):
6767
clone_cmd = ["git", "clone",
6868
"https://github.com/KhronosGroup/OpenCL-ICD-Loader",
69-
"OpenCL-ICD-Loader", "-b", "v2020.06.16"]
69+
"OpenCL-ICD-Loader", "-b", "master"]
7070

7171
subprocess.check_call(clone_cmd, cwd=args.obj_dir)
7272
else:
7373
fetch_cmd = ["git", "pull", "--ff", "--ff-only", "origin"]
7474
subprocess.check_call(fetch_cmd, cwd=icd_loader_dir)
7575

76+
# Checkout fixed version to avoid unexpected issues coming from upstream
77+
# Specific version can be uplifted as soon as such need arise
78+
checkout_cmd = ["git", "checkout", "5f8249691ec8c25775789498951f8e9eb62c201d"]
79+
subprocess.check_call(checkout_cmd, cwd=icd_loader_dir)
80+
7681
icd_build_dir = os.path.join(icd_loader_dir, "build")
7782
if os.path.isdir(icd_build_dir):
7883
shutil.rmtree(icd_build_dir)
@@ -119,4 +124,3 @@ def main():
119124
ret = main()
120125
exit_code = 0 if ret else 1
121126
sys.exit(exit_code)
122-

opencl-aot/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ if (NOT OpenCL_INCLUDE_DIRS)
1717
set(OpenCL_INCLUDE_DIRS "${CMAKE_CURRENT_BINARY_DIR}/OpenCL/inc")
1818
ExternalProject_Add(opencl-headers
1919
GIT_REPOSITORY https://github.com/KhronosGroup/OpenCL-Headers.git
20-
GIT_TAG d1b936b72b9610626ecab8a991cec18348fba047
20+
GIT_TAG 23710f1b99186065c1768fc3098ba681adc0f253
2121
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/OpenCL/inc"
2222
CONFIGURE_COMMAND ""
2323
BUILD_COMMAND ${CMAKE_COMMAND} -E copy_directory ${OpenCL_INCLUDE_DIRS}/CL ${CMAKE_CURRENT_BINARY_DIR}/inc/CL
@@ -48,7 +48,7 @@ if (NOT OpenCL_LIBRARIES)
4848
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/icd_build)
4949
ExternalProject_Add(opencl-icd
5050
GIT_REPOSITORY https://github.com/KhronosGroup/OpenCL-ICD-Loader.git
51-
GIT_TAG v2020.06.16
51+
GIT_TAG 5f8249691ec8c25775789498951f8e9eb62c201d
5252
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/OpenCL/icd"
5353
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/icd_build"
5454
CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}

sycl/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ if( NOT OpenCL_INCLUDE_DIRS )
100100
endif()
101101
ExternalProject_Add(ocl-headers
102102
GIT_REPOSITORY https://github.com/KhronosGroup/OpenCL-Headers.git
103-
GIT_TAG d1b936b72b9610626ecab8a991cec18348fba047
103+
GIT_TAG 23710f1b99186065c1768fc3098ba681adc0f253
104104
UPDATE_DISCONNECTED ${SYCL_EP_OCL_HEADERS_SKIP_AUTO_UPDATE}
105105
SOURCE_DIR ${OpenCL_INCLUDE_DIRS}
106106
CONFIGURE_COMMAND ""
@@ -144,7 +144,7 @@ if( NOT OpenCL_LIBRARIES )
144144
endif()
145145
ExternalProject_Add(ocl-icd
146146
GIT_REPOSITORY https://github.com/KhronosGroup/OpenCL-ICD-Loader.git
147-
GIT_TAG v2020.06.16
147+
GIT_TAG 5f8249691ec8c25775789498951f8e9eb62c201d
148148
UPDATE_DISCONNECTED ${SYCL_EP_OCL_ICD_SKIP_AUTO_UPDATE}
149149
SOURCE_DIR ${OpenCL_ICD_LOADER_SOURCE_DIR}
150150
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/icd_build"

0 commit comments

Comments
 (0)