Skip to content

Commit efd0fc5

Browse files
committed
Fix Merge
* Use convertToOpenCLType helper
1 parent ddcb510 commit efd0fc5

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

sycl/include/sycl/detail/image_ocl_types.hpp

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -85,27 +85,23 @@ static RetType __invoke__ImageArrayRead(ImageT Img, CoordT Coords,
8585

8686
// Convert from sycl types to builtin types to get correct function mangling.
8787
using TempRetT = sycl::detail::ConvertToOpenCLType_t<RetType>;
88-
using TempArgT = sycl::detail::ConvertToOpenCLType_t<CoordT>;
88+
auto TmpCoords = sycl::detail::convertToOpenCLType(Coords);
8989

90-
TempArgT Arg = sycl::detail::convertDataToType<CoordT, TempArgT>(Coords);
91-
TempRetT Ret =
92-
__spirv_ImageArrayRead<TempRetT, ImageT, TempArgT>(Img, Arg, ArrayLayer);
93-
return sycl::detail::convertDataToType<TempRetT, RetType>(Ret);
90+
return sycl::detail::convertFromOpenCLTypeFor<RetType>(
91+
__spirv_ImageArrayRead<TempRetT, ImageT, decltype(TmpCoords)>(
92+
Img, TmpCoords, ArrayLayer));
9493
}
9594

9695
template <typename ImageT, typename CoordT, typename ValT>
9796
static void __invoke__ImageArrayWrite(ImageT Img, CoordT Coords, int ArrayLayer,
9897
ValT Val) {
9998

10099
// Convert from sycl types to builtin types to get correct function mangling.
101-
using TmpValT = sycl::detail::ConvertToOpenCLType_t<ValT>;
102-
using TmpCoordT = sycl::detail::ConvertToOpenCLType_t<CoordT>;
103-
104-
TmpCoordT TmpCoord =
105-
sycl::detail::convertDataToType<CoordT, TmpCoordT>(Coords);
106-
TmpValT TmpVal = sycl::detail::convertDataToType<ValT, TmpValT>(Val);
107-
__spirv_ImageArrayWrite<ImageT, TmpCoordT, TmpValT>(Img, TmpCoord, ArrayLayer,
108-
TmpVal);
100+
auto TmpCoords = sycl::detail::convertToOpenCLType(Coords);
101+
auto TmpVal = sycl::detail::convertToOpenCLType(Val);
102+
103+
__spirv_ImageArrayWrite<ImageT, decltype(TmpCoords), decltype(TmpVal)>(
104+
Img, TmpCoords, ArrayLayer, TmpVal);
109105
}
110106

111107
template <typename RetType, typename SmpImageT, typename CoordT>

0 commit comments

Comments
 (0)