[SYCL][NFC] Fixed static analysis warnings in LowerESIMD.cpp

Author: DenisBakhvalov

llvm/lib/SYCLLowerIR/LowerESIMD.cpp

@@ -579,6 +579,7 @@ template <typename Ty = llvm::Value> Ty *getVal(llvm::Metadata *M) {
 static llvm::MDNode *getSLMSizeMDNode(llvm::Function *F) {
   llvm::NamedMDNode *Nodes =
       F->getParent()->getNamedMetadata(GENX_KERNEL_METADATA);
+  assert(Nodes && "invalid genx.kernels metadata");
   for (auto Node : Nodes->operands()) {
     if (Node->getNumOperands() >= 4 && getVal(Node->getOperand(0)) == F)
       return Node;
@@ -626,6 +627,8 @@ static void translateSLMInit(CallInst &CI) {
 static void translatePackMask(CallInst &CI) {
   using Demangler = id::ManglingParser<SimpleAllocator>;
   Function *F = CI.getCalledFunction();
+  assert(F && "function to translate is invalid");
+
   StringRef MnglName = F->getName();
   Demangler Parser(MnglName.begin(), MnglName.end());
   id::Node *AST = Parser.parse();
@@ -665,6 +668,7 @@ static void translatePackMask(CallInst &CI) {
 static void translateUnPackMask(CallInst &CI) {
   using Demangler = id::ManglingParser<SimpleAllocator>;
   Function *F = CI.getCalledFunction();
+  assert(F && "function to translate is invalid");
   StringRef MnglName = F->getName();
   Demangler Parser(MnglName.begin(), MnglName.end());
   id::Node *AST = Parser.parse();
@@ -729,7 +733,7 @@ static void translateGetValue(CallInst &CI) {
   IRBuilder<> Builder(&CI);
   auto SV =
       Builder.CreatePtrToInt(opnd, IntegerType::getInt32Ty(CI.getContext()));
-  auto *SI = dyn_cast<CastInst>(SV);
+  auto *SI = cast<CastInst>(SV);
   SI->setDebugLoc(CI.getDebugLoc());
   CI.replaceAllUsesWith(SI);
 }
@@ -1018,6 +1022,7 @@ static void createESIMDIntrinsicArgs(const ESIMDIntrinDesc &Desc,
 static void translateESIMDIntrinsicCall(CallInst &CI) {
   using Demangler = id::ManglingParser<SimpleAllocator>;
   Function *F = CI.getCalledFunction();
+  assert(F && "function to translate is invalid");
   StringRef MnglName = F->getName();
   Demangler Parser(MnglName.begin(), MnglName.end());
   id::Node *AST = Parser.parse();
@@ -1039,7 +1044,7 @@ static void translateESIMDIntrinsicCall(CallInst &CI) {
   if (!Desc.isValid()) // TODO remove this once all intrinsics are supported
     return;
 
-  auto *FTy = CI.getCalledFunction()->getFunctionType();
+  auto *FTy = F->getFunctionType();
   std::string Suffix = getESIMDIntrinSuffix(FE, FTy, Desc.SuffixRule);
   auto ID = GenXIntrinsic::lookupGenXIntrinsicID(
       GenXIntrinsic::getGenXIntrinsicPrefix() + Desc.GenXSpelling + Suffix);