Skip to content

Commit f27d391

Browse files
committed
[NativeCPU] implement missing query for HOST_PIPE support
and skip pipe and fill2d tests if the feature is not supported
1 parent bf33724 commit f27d391

File tree

8 files changed

+19
-21
lines changed

8 files changed

+19
-21
lines changed

source/adapters/native_cpu/device.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
420420
case UR_DEVICE_INFO_ENQUEUE_NATIVE_COMMAND_SUPPORT_EXP:
421421
return ReturnValue(false);
422422

423+
case UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED:
424+
return ReturnValue(ur_bool_t{false});
425+
423426
case UR_DEVICE_INFO_USM_POOL_SUPPORT:
424427
return ReturnValue(false);
425428

test/conformance/device/device_adapter_native_cpu.match

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUB_GROUP_INDEPENDENT_FORWARD_PROGRES
1111
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_COMPUTE_QUEUE_INDICES
1212
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_WORK_GROUPS_3D
1313
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ASYNC_BARRIER
14-
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED
1514
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ATOMIC_FENCE_SCOPE_CAPABILITIES
1615
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ATOMIC_MEMORY_SCOPE_CAPABILITIES
1716
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS

test/conformance/enqueue/enqueue_adapter_level_zero.match

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
{{OPT}}urEnqueueMemImageWriteTest.InvalidRegion3D/*
5555
{{OPT}}urEnqueueKernelLaunchMultiDeviceTest.KernelLaunchReadDifferentQueues/*
5656
urEnqueueUSMAdviseTest.InvalidSizeTooLarge/*
57-
urEnqueueUSMFill2DNegativeTest.OutOfBounds/*
5857
{{OPT}}urEnqueueUSMMemcpyTest.Blocking/*
5958
{{OPT}}urEnqueueUSMMemcpyTest.BlockingWithEvent/*
6059
{{OPT}}urEnqueueUSMMemcpyTest.WaitForDependencies/*

test/conformance/enqueue/enqueue_adapter_level_zero_v2.match

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ urEnqueueKernelLaunchKernelWgSizeTest.Success/*
6868
{{OPT}}urEnqueueMemImageWriteTest.InvalidRegion2D/*
6969
{{OPT}}urEnqueueMemImageWriteTest.InvalidRegion3D/*
7070
{{OPT}}urEnqueueKernelLaunchMultiDeviceTest.KernelLaunchReadDifferentQueues/*
71-
urEnqueueUSMFill2DNegativeTest.OutOfBounds/*
7271
urEnqueueUSMAdviseTest.InvalidSizeTooLarge/*
7372
urEnqueueUSMPrefetchTest.InvalidSizeTooLarge/*
7473
{{OPT}}urEnqueueTimestampRecordingExpTest.SuccessBlocking/*

test/conformance/enqueue/enqueue_adapter_native_cpu.match

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -139,16 +139,6 @@ urEnqueueEventsWaitWithBarrierOrderingTest.SuccessNonEventDependencies/*_
139139
{{OPT}}urEnqueueUSMPrefetchTest.InvalidSizeZero/*
140140
{{OPT}}urEnqueueUSMPrefetchTest.InvalidSizeTooLarge/*
141141
{{OPT}}urEnqueueUSMPrefetchTest.InvalidEventWaitList/*
142-
{{OPT}}urEnqueueReadHostPipeTest.InvalidNullHandleQueue/*
143-
{{OPT}}urEnqueueReadHostPipeTest.InvalidNullHandleProgram/*
144-
{{OPT}}urEnqueueReadHostPipeTest.InvalidNullPointerPipeSymbol/*
145-
{{OPT}}urEnqueueReadHostPipeTest.InvalidNullPointerBuffer/*
146-
{{OPT}}urEnqueueReadHostPipeTest.InvalidEventWaitList/*
147-
{{OPT}}urEnqueueWriteHostPipeTest.InvalidNullHandleQueue/*
148-
{{OPT}}urEnqueueWriteHostPipeTest.InvalidNullHandleProgram/*
149-
{{OPT}}urEnqueueWriteHostPipeTest.InvalidNullPointerPipeSymbol/*
150-
{{OPT}}urEnqueueWriteHostPipeTest.InvalidNullPointerBuffer/*
151-
{{OPT}}urEnqueueWriteHostPipeTest.InvalidEventWaitList/*
152142
urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest.Success/*
153143
urEnqueueKernelLaunchIncrementMultiDeviceTest.Success/*
154144
urEnqueueKernelLaunchIncrementTest.Success/*

test/conformance/enqueue/urEnqueueUSMFill2D.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ TEST_P(urEnqueueUSMFill2DTestWithParam, Success) {
134134

135135
ur_event_handle_t event = nullptr;
136136

137-
ASSERT_SUCCESS(urEnqueueUSMFill2D(queue, ptr, pitch, pattern_size,
138-
pattern.data(), width, height, 0, nullptr,
139-
&event));
137+
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
138+
urEnqueueUSMFill2D(queue, ptr, pitch, pattern_size, pattern.data(),
139+
width, height, 0, nullptr, &event));
140140
EXPECT_SUCCESS(urQueueFlush(queue));
141141

142142
ASSERT_SUCCESS(urEventWait(1, &event));
@@ -161,6 +161,11 @@ struct urEnqueueUSMFill2DNegativeTest : uur::urQueueTest {
161161

162162
ASSERT_SUCCESS(urUSMDeviceAlloc(context, device, nullptr, nullptr,
163163
allocation_size, &ptr));
164+
165+
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
166+
urEnqueueUSMFill2D(queue, ptr, pitch, pattern_size, pattern.data(),
167+
width, height, 0, nullptr, nullptr));
168+
ASSERT_SUCCESS(urQueueFinish(queue));
164169
}
165170

166171
void TearDown() override {

test/conformance/memory/urMemImageCreateWithNativeHandle.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urMemImageCreateWithNativeHandleTest);
1010

1111
TEST_P(urMemImageCreateWithNativeHandleTest, Success) {
1212
ur_native_handle_t native_handle = 0;
13-
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(urMemGetNativeHandle(image, device, &native_handle));
13+
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
14+
urMemGetNativeHandle(image, device, &native_handle));
1415

1516
ur_mem_handle_t mem = nullptr;
1617
ASSERT_SUCCESS(urMemImageCreateWithNativeHandle(

test/conformance/testing/include/uur/fixtures.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,17 +374,14 @@ struct urQueueTest : urContextTest {
374374
struct urHostPipeTest : urQueueTest {
375375
void SetUp() override {
376376
UUR_RETURN_ON_FATAL_FAILURE(urQueueTest::SetUp());
377-
UUR_RETURN_ON_FATAL_FAILURE(
378-
uur::KernelsEnvironment::instance->LoadSource("foo", il_binary));
379-
ASSERT_SUCCESS(uur::KernelsEnvironment::instance->CreateProgram(
380-
platform, context, device, *il_binary, nullptr, &program));
381377

382378
size_t size = 0;
383379
ASSERT_SUCCESS(urDeviceGetInfo(
384380
device, UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED, 0, nullptr,
385381
&size));
386382
ASSERT_NE(size, 0);
387383
ASSERT_EQ(sizeof(ur_bool_t), size);
384+
388385
void *info_data = alloca(size);
389386
ASSERT_SUCCESS(urDeviceGetInfo(
390387
device, UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED, size,
@@ -396,6 +393,11 @@ struct urHostPipeTest : urQueueTest {
396393
if (!supported) {
397394
GTEST_SKIP() << "Host pipe read/write is not supported.";
398395
}
396+
397+
UUR_RETURN_ON_FATAL_FAILURE(
398+
uur::KernelsEnvironment::instance->LoadSource("foo", il_binary));
399+
ASSERT_SUCCESS(uur::KernelsEnvironment::instance->CreateProgram(
400+
platform, context, device, *il_binary, nullptr, &program));
399401
}
400402

401403
void TearDown() override {

0 commit comments

Comments
 (0)