Skip to content

Commit f447006

Browse files
committed
removed __SYCL_EXPORT in pi_opencl.cpp because we
already attached it in pi.h Signed-off-by: Byoungro So <[email protected]>
1 parent 89a1cc8 commit f447006

File tree

2 files changed

+116
-115
lines changed

2 files changed

+116
-115
lines changed

sycl/plugins/opencl/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
1414

1515
# We chose MODULE type because libpi_opencl.so should never be linked dynamically to a target.
16-
# MODULE will limit this library to be used to load symbols via dllopen only
16+
# MODULE will limit this library to be used to load symbols via dlopen only
1717
add_library(pi_opencl MODULE
1818
"${sycl_inc_dir}/CL/sycl/detail/pi.h"
1919
"pi_opencl.cpp"
@@ -37,11 +37,11 @@ target_link_libraries( pi_opencl
3737
)
3838
if (MSVC)
3939
# by defining __SYCL_BUILD_SYCL_DLL, we can use __declspec(dllexport)
40-
# which are individually tagged for all pi* symbols in pi_opencl.cpp
40+
# which are individually tagged for all pi* symbols in pi.h
4141
target_compile_definitions(pi_opencl PRIVATE __SYCL_BUILD_SYCL_DLL)
4242
else()
4343
# we set the visibility of all symbols 'hidden' by default.
44-
# In *.cpp files, we set exported symbols with visibility==default individually
44+
# In pi.h file, we set exported symbols with visibility==default individually
4545
target_compile_options(pi_opencl PUBLIC -fvisibility=hidden)
4646

4747
# This script file is used to allow exporting pi* symbols only.

0 commit comments

Comments
 (0)