Skip to content

Commit f6b952d

Browse files
authored
[CI] Use same image name but different tag (#13309)
When we push the built docker image with tags, it will be stored in github as a package. The default package is private. When we create name image names, they are all private by default. Hence we can't access `_unstable` or `_devigc` images after refactoring. See https://github.com/intel/llvm/actions/runs/8574917864/job/23502927206?pr=13305 > /usr/bin/docker pull "ghcr.io/intel/llvm/ubuntu2204_intel_drivers_devigc:latest" > Error response from daemon: Head "https://ghcr.io/v2/intel/llvm/ubuntu2204_intel_drivers_devigc/manifests/latest": unauthorized > Warning: Docker pull failed with exit code 1, back off 2.664 seconds before retry." Also the package permission control is in github org level, not in repo level, so even the repo admin can't mark them as public. To avoid applying for more public images from org level, we can use same images but different tags for our images, as the existing images have been marked as public.
1 parent 59a5521 commit f6b952d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/sycl-containers.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,25 @@ jobs:
3535
include:
3636
- name: Base Ubuntu 22.04 Docker image
3737
file: ubuntu2204_base
38-
tags: ubuntu2204_base
38+
tag: latest
3939
build_args: ""
4040
- name: Build Ubuntu Docker image
4141
file: ubuntu2204_build
42-
tags: ubuntu2204_build
42+
tag: latest
4343
build_args: ""
4444
- name: Intel Drivers Ubuntu 22.04 Docker image
4545
file: ubuntu2204_intel_drivers
46-
tags: ubuntu2204_intel_drivers
46+
tag: latest
4747
build_args: "use_latest=false"
4848
- name: Intel Drivers Ubuntu 22.04 Docker image with dev IGC
4949
file: ubuntu2204_intel_drivers
50-
tags: ubuntu2204_intel_drivers_devigc
50+
tag: devigc
5151
build_args: |
5252
"use_latest=false"
5353
"use_igc_dev=true"
5454
- name: Intel Drivers (unstable) Ubuntu 22.04 Docker image
5555
file: ubuntu2204_intel_drivers
56-
tags: ubuntu2204_intel_drivers_unstable
56+
tag: unstable
5757
build_args: "use_latest=true"
5858
steps:
5959
- name: Checkout
@@ -68,7 +68,7 @@ jobs:
6868
username: ${{ github.repository_owner }}
6969
password: ${{ secrets.GITHUB_TOKEN }}
7070
tags: |
71-
ghcr.io/${{ github.repository }}/${{ matrix.tags }}-${{ github.sha }}
72-
ghcr.io/${{ github.repository }}/${{ matrix.tags }}:latest
71+
ghcr.io/${{ github.repository }}/${{ matrix.file }}:${{ matrix.tag }}-${{ github.sha }}
72+
ghcr.io/${{ github.repository }}/${{ matrix.file }}:${{ matrix.tag }}
7373
build-args: ${{ matrix.build_args }}
7474

0 commit comments

Comments
 (0)