[SYCL][Docs] Fix variadic properties ctor (#13676)

The [compile-time properties
extension](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_properties.asciidoc)
specifies that the variadic ctor has the following behavior:

>Available only when each argument in props is an object of a property
value. Construct a property list with zero or more property values. This
constructor can accept both runtime and compile-time constant property
values. Each property in the property list (as determined by
PropertyValuesT) that is not default constructable must have an object
provided in props.

However, the current implementation does not adhere to these
requirements. This commit makes the following changes to adhere to the
required behavior:

* The ctor is now SFINAE'd out when arguments are non-property types.
* Each argument must now have a corresponding property in the list.
* Default-constructible arguments can now be omitted from the arguments.
This only applied to compile-time properties previously.

Additionally, this exposed bugs in a set of extensions relying on these
properties, which has in turn also been fixed with this commit.

---------

Signed-off-by: Larsen, Steffen <[email protected]>

Author: steffenlarsen

sycl/doc/extensions/experimental/sycl_ext_oneapi_annotated_arg.asciidoc

@@ -200,7 +200,7 @@ template <typename T, typename PropertyListT = empty_properties_t>
 class annotated_arg {
   public:
     annotated_arg() noexcept;
-    annotated_arg(const T& v_, const PropertyListT &P = properties{}) noexcept;
+    annotated_arg(const T& v_, const PropertyListT &P = PropertyListT{}) noexcept;
     template<typename... PropertyValueTs>
     annotated_arg(const T& v_, PropertyValueTs... props) noexcept;
 
@@ -277,7 +277,7 @@ Constructs an `annotated_arg` object which is default initialized.
 a|
 [source,c++]
 ----
-annotated_arg(const T& v_, const PropertyListT &P = properties{}) noexcept;
+annotated_arg(const T& v_, const PropertyListT &P = PropertyListT{}) noexcept;
 ----
 | Not available in device code.
 Constructs an `annotated_arg` object from the input object `v_`.

sycl/doc/extensions/experimental/sycl_ext_oneapi_annotated_ptr.asciidoc

@@ -287,7 +287,7 @@ class annotated_ptr {
     using reference = annotated_ref<T, PropertyListT>;
 
     annotated_ptr() noexcept;
-    explicit annotated_ptr(T *Ptr, const PropertyListT &P = properties{}) noexcept;
+    explicit annotated_ptr(T *Ptr, const PropertyListT &P = PropertyListT{}) noexcept;
     template<typename... PropertyValueTs>
     explicit annotated_ptr(T *Ptr, PropertyValueTs... props) noexcept;
 
@@ -359,7 +359,7 @@ underlying pointer is initialized to `nullptr`.
 a|
 [source,c++]
 ----
-explicit annotated_ptr(T *Ptr, const PropertyListT &P = properties{}) noexcept;
+explicit annotated_ptr(T *Ptr, const PropertyListT &P = PropertyListT{}) noexcept;
 ----
 |
 Constructs an `annotated_ptr` object. Does not allocate new storage. The

sycl/doc/extensions/proposed/sycl_ext_oneapi_usm_malloc_properties.asciidoc

@@ -281,7 +281,7 @@ malloc_device_annotated(
    size_t numBytes,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on `syclDevice`.
 The allocation size is specified in bytes.
@@ -316,7 +316,7 @@ malloc_device_annotated(
    size_t count,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@  Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on `syclDevice`.
 The allocation size is specified in number of elements of type
@@ -349,7 +349,7 @@ annotated_ptr<void, propertyListB>
 malloc_device_annotated(
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device`
 and `context`.
@@ -364,7 +364,7 @@ annotated_ptr<T, propertyListB>
 malloc_device_annotated(
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device`
 and `context`.
@@ -379,7 +379,7 @@ aligned_alloc_device_annotated(
    size_t numBytes,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on
 `syclDevice`.
@@ -417,7 +417,7 @@ aligned_alloc_device_annotated(
    size_t count,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on
 `syclDevice`.
@@ -452,7 +452,7 @@ aligned_alloc_device_annotated(
    size_t alignment,
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device`
 and `context`.
@@ -468,7 +468,7 @@ aligned_alloc_device_annotated(
    size_t alignment,
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device`
 and `context`.
@@ -497,7 +497,7 @@ annotated_ptr<void, propertyListB>
 malloc_host_annotated(
    size_t numBytes,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory. This allocation is specified in bytes.
 
@@ -526,7 +526,7 @@ annotated_ptr<T, propertyListB>
 malloc_host_annotated(
    size_t count,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory. This allocation is specified in number of elements of type `T`.
 
@@ -553,7 +553,7 @@ annotated_ptr<void, propertyListB>
 malloc_host_annotated(
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`.
 
@@ -567,7 +567,7 @@ annotated_ptr<T, propertyListB>
 malloc_host_annotated(
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`.
 
@@ -580,7 +580,7 @@ aligned_alloc_host_annotated(
    size_t alignment,
    size_t numBytes,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory.
 This allocation is specified in bytes and aligned according to `alignment`.
@@ -611,7 +611,7 @@ aligned_alloc_host_annotated(
    size_t alignment,
    size_t count,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory.
 This allocation is specified in elements of type `T` and aligned according to `alignment`.
@@ -640,7 +640,7 @@ aligned_alloc_host_annotated(
    size_t alignment,
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`.
 
@@ -655,7 +655,7 @@ aligned_alloc_host_annotated(
    size_t alignment,
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`.
 
@@ -683,7 +683,7 @@ malloc_shared_annotated(
    size_t numBytes,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
 This allocation is specified in bytes.
@@ -718,7 +718,7 @@ malloc_shared_annotated(
    size_t count,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
 This allocation is specified in number of elements of
@@ -751,7 +751,7 @@ annotated_ptr<void, propertyListB>
 malloc_shared_annotated(
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device` and
 `context`.
@@ -766,7 +766,7 @@ annotated_ptr<T, propertyListB>
 malloc_shared_annotated(
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device` and
 `context`.
@@ -781,7 +781,7 @@ aligned_alloc_shared_annotated(
    size_t numBytes,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
 This allocation is specified in bytes and aligned according to `alignment`.
@@ -817,7 +817,7 @@ aligned_alloc_shared_annotated(
    size_t count,
    const device& syclDevice,
    const context& syclContext,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
 This allocation is specified in number of elements of type `T` and aligned according to `alignment`. 
@@ -850,7 +850,7 @@ aligned_alloc_shared_annotated(
    size_t alignment,
    size_t numBytes,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device` and
 `context`.
@@ -866,7 +866,7 @@ aligned_alloc_shared_annotated(
    size_t alignment,
    size_t count,
    const queue& syclQueue,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `device` and
 `context`.
@@ -907,7 +907,7 @@ malloc_annotated(
    const device& syclDevice,
    const context& syclContext,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
 This allocation size is specified in bytes.
@@ -940,7 +940,7 @@ malloc_annotated(
    const device& syclDevice,
    const context& syclContext,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
 This allocation is specified in number of elements of type `T`.
@@ -971,7 +971,7 @@ malloc_annotated(
    size_t numBytes,
    const queue& syclQueue,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`
 and any necessary `device`.
@@ -987,7 +987,7 @@ malloc_annotated(
    size_t count,
    const queue& syclQueue,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`
 and any necessary `device`.
@@ -1003,7 +1003,7 @@ aligned_alloc_annotated(
    const device& syclDevice,
    const context& syclContext,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
 This allocation is specified in bytes and is aligned according to `alignment`.
@@ -1037,7 +1037,7 @@ aligned_alloc_annotated(
    const device& syclDevice,
    const context& syclContext,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
 This allocation is specified in number of elements of type `T` and is aligned according to `alignment`.
@@ -1068,7 +1068,7 @@ aligned_alloc_annotated(
    size_t numBytes,
    const queue& syclQueue,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`
 and any necessary `device`.
@@ -1085,7 +1085,7 @@ aligned_alloc_annotated(
    size_t count,
    const queue& syclQueue,
    sycl::usm::alloc kind,
-   const propertyListA &propList = properties{})
+   const propertyListA &propList = propertyListA{})
 ----
 a@ Simplified form where `syclQueue` provides the `context`
 and any necessary `device`.

sycl/include/sycl/ext/oneapi/experimental/annotated_arg/annotated_arg.hpp

@@ -114,7 +114,7 @@ __SYCL_TYPE(annotated_arg) annotated_arg<T *, detail::properties_t<Props...>> {
   annotated_arg &operator=(annotated_arg &) = default;
 
   annotated_arg(T *_ptr,
-                const property_list_t &PropList = properties{}) noexcept
+                const property_list_t &PropList = property_list_t{}) noexcept
       : obj(_ptr) {
     (void)PropList;
   }
@@ -250,7 +250,7 @@ __SYCL_TYPE(annotated_arg) annotated_arg<T, detail::properties_t<Props...>> {
   annotated_arg &operator=(annotated_arg &) = default;
 
   annotated_arg(const T &_obj,
-                const property_list_t &PropList = properties{}) noexcept
+                const property_list_t &PropList = property_list_t{}) noexcept
       : obj(_obj) {
     (void)PropList;
   }

sycl/include/sycl/ext/oneapi/experimental/annotated_ptr/annotated_ptr.hpp

@@ -303,7 +303,7 @@ __SYCL_TYPE(annotated_ptr) annotated_ptr<T, detail::properties_t<Props...>> {
   annotated_ptr &operator=(const annotated_ptr &) = default;
 
   explicit annotated_ptr(T *Ptr,
-                         const property_list_t & = properties{}) noexcept
+                         const property_list_t & = property_list_t{}) noexcept
       : m_Ptr(Ptr) {}
 
   // Constructs an annotated_ptr object from a raw pointer and variadic