[CodeGen][NFCI] Avoid calls to setTargetAttributes on definitions

Alex Gatea · cebowler · commit fb9a74122ef7 · 2023-07-12T09:29:11.000-04:00
Avoid duplicate calls to setTargetAttributes on global variable definitions. Differential: https://reviews.llvm.org/D153903
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -4765,7 +4765,8 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty,
     }
   }
 
-  if (GV->isDeclaration()) {
+  if (D &&
+      D->isThisDeclarationADefinition(Context) == VarDecl::DeclarationOnly) {
     getTargetCodeGenInfo().setTargetAttributes(D, GV, *this);
     // External HIP managed variables needed to be recorded for transformation
     // in both device and host compilations.

Original file line number	Diff line number	Diff line change
`@@ -4765,7 +4765,8 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty,`
`4765`	`4765`	`}`
`4766`	`4766`	`}`
`4767`	`4767`
`4768`		`- if (GV->isDeclaration()) {`
	`4768`	`+ if (D &&`
	`4769`	`+ D->isThisDeclarationADefinition(Context) == VarDecl::DeclarationOnly) {`
`4769`	`4770`	`getTargetCodeGenInfo().setTargetAttributes(D, GV, *this);`
`4770`	`4771`	`// External HIP managed variables needed to be recorded for transformation`
`4771`	`4772`	`// in both device and host compilations.`