You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert "[SYCL] Adds complex Literals support to sycl::experimental::complex" (#10521)
Reverts #9819
As mentioned in the PR #9867, this
introduction of literal operators creates some issues due to literal
operators receiving arguments as `long double` which are not supported
on device code (and only works on host side); and our worries that users
will try to use it and will not understand why it does not work.
Also, user-defined literal operators should be declared with a `_`
prefix to not clash with the standard literal operators when `using
namespace std::literals`.
Reverting this PR will facilitate the merge of the previously mentioned
PR and have a place where the issues from this introduction are listed.
Regardless of this PR, we'd still like to have support for literal
operators for complex, so if you (@abagusetty) could open up a new PR
for re-introducing the literal operator if a solution can be found also
to handle it in device code, that would be great!
@gmlueck@abagusetty
Copy file name to clipboardExpand all lines: sycl/doc/extensions/proposed/sycl_ext_oneapi_complex.asciidoc
-27Lines changed: 0 additions & 27 deletions
Original file line number
Diff line number
Diff line change
@@ -438,33 +438,6 @@ mathematical operation.
438
438
|Compute the hyperbolic tangent of complex number x.
439
439
|===
440
440
441
-
442
-
=== Suffixes for complex number literals
443
-
444
-
This proposal describes literal suffixes for constructing complex number literals.
445
-
The suffixes `i` and `if` create complex numbers of the types `complex<double>` and `complex<float>` respectively, with their imaginary part denoted by the given literal number and the real part being zero.
0 commit comments