[SYCL][CUDA] Add mem_advise reset and managed mem check (#5536)

This PR adds the mem_advise reset case and a managed memory check in cuda_piextUSMEnqueueMemAdvise.

cuMemAdvise only works on managed memory and returns an error if host or device memory is passed.
The SYCL-CTS tests mem_advise with host and device memory, which are not managed.  This PR prevents an error from being thrown in the cts usm test.

In addition, the sycl spec specifies for mem_advise `A value of 0 reverts the advice for ptr to the default behavior`, currently a value of 0 is treated as unknown and throws an error in the cts as well. This reset case is added to mem_advise.

This patch along with #5446 resolves issue #5209 

This change breaks the ABI

Author: AidanBeltonS

sycl/include/sycl/detail/pi.h

@@ -47,9 +47,11 @@
 // 8.10 Added new optional device argument to piextQueueCreateWithNativeHandle
 // 9.11 Use values of OpenCL enums directly, rather than including `<CL/cl.h>`;
 // NOTE that this results in a changed API for `piProgramGetBuildInfo`.
+// 10.12 Change enum value PI_MEM_ADVICE_UNKNOWN from 0 to 999, and set enum
+// PI_MEM_ADVISE_RESET to 0.
 
-#define _PI_H_VERSION_MAJOR 9
-#define _PI_H_VERSION_MINOR 11
+#define _PI_H_VERSION_MAJOR 10
+#define _PI_H_VERSION_MINOR 12
 
 #define _PI_STRING_HELPER(a) #a
 #define _PI_CONCAT(a, b) _PI_STRING_HELPER(a.b)
@@ -404,7 +406,7 @@ typedef enum {
 
 typedef enum {
   // Device-specific value opaque in PI API.
-  PI_MEM_ADVICE_UNKNOWN,
+  PI_MEM_ADVICE_RESET = 0,
   PI_MEM_ADVICE_CUDA_SET_READ_MOSTLY = 101,
   PI_MEM_ADVICE_CUDA_UNSET_READ_MOSTLY = 102,
   PI_MEM_ADVICE_CUDA_SET_PREFERRED_LOCATION = 103,
@@ -415,6 +417,7 @@ typedef enum {
   PI_MEM_ADVICE_CUDA_UNSET_PREFERRED_LOCATION_HOST = 108,
   PI_MEM_ADVICE_CUDA_SET_ACCESSED_BY_HOST = 109,
   PI_MEM_ADVICE_CUDA_UNSET_ACCESSED_BY_HOST = 110,
+  PI_MEM_ADVICE_UNKNOWN = 999,
 } _pi_mem_advice;
 
 typedef enum {

sycl/plugins/cuda/pi_cuda.cpp

@@ -5099,7 +5099,8 @@ pi_result cuda_piextUSMEnqueueMemAdvise(pi_queue queue, const void *ptr,
   if (advice == PI_MEM_ADVICE_CUDA_SET_PREFERRED_LOCATION ||
       advice == PI_MEM_ADVICE_CUDA_UNSET_PREFERRED_LOCATION ||
       advice == PI_MEM_ADVICE_CUDA_SET_ACCESSED_BY ||
-      advice == PI_MEM_ADVICE_CUDA_UNSET_ACCESSED_BY) {
+      advice == PI_MEM_ADVICE_CUDA_UNSET_ACCESSED_BY ||
+      advice == PI_MEM_ADVICE_RESET) {
     pi_device device = queue->get_context()->get_device();
     if (!getAttribute(device, CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS)) {
       setErrorMessage("Mem advise ignored as device does not support "
@@ -5148,6 +5149,17 @@ pi_result cuda_piextUSMEnqueueMemAdvise(pi_queue queue, const void *ptr,
                           PI_MEM_ADVICE_CUDA_SET_PREFERRED_LOCATION)),
           CU_DEVICE_CPU));
       break;
+    case PI_MEM_ADVICE_RESET:
+      PI_CHECK_ERROR(cuMemAdvise((CUdeviceptr)ptr, length,
+                                 CU_MEM_ADVISE_UNSET_READ_MOSTLY,
+                                 queue->get_context()->get_device()->get()));
+      PI_CHECK_ERROR(cuMemAdvise((CUdeviceptr)ptr, length,
+                                 CU_MEM_ADVISE_UNSET_PREFERRED_LOCATION,
+                                 queue->get_context()->get_device()->get()));
+      PI_CHECK_ERROR(cuMemAdvise((CUdeviceptr)ptr, length,
+                                 CU_MEM_ADVISE_UNSET_ACCESSED_BY,
+                                 queue->get_context()->get_device()->get()));
+      break;
     default:
       cl::sycl::detail::pi::die("Unknown advice");
     }