Review comments - remove __esimd_bitcast, improve bfloat16 traits

kbobrovs · kbobrovs · commit fe312534ba26 · 2022-09-01T16:04:11.000-07:00
diff --git a/llvm/lib/SYCLLowerIR/ESIMD/ESIMDVerifier.cpp b/llvm/lib/SYCLLowerIR/ESIMD/ESIMDVerifier.cpp
@@ -46,6 +46,7 @@ static const char *LegalSYCLFunctions[] = {
     "^sycl::_V1::sin<.+>",
     "^sycl::_V1::log<.+>",
     "^sycl::_V1::exp<.+>",
+    "^sycl::_V1::bit_cast<.+>",
     "^sycl::_V1::operator.+<.+>",
     "^sycl::_V1::ext::oneapi::sub_group::.+",
     "^sycl::_V1::ext::oneapi::experimental::spec_constant<.+>::.+",
diff --git a/sycl/include/sycl/ext/intel/esimd/detail/bfloat16_type_traits.hpp b/sycl/include/sycl/ext/intel/esimd/detail/bfloat16_type_traits.hpp
@@ -58,7 +58,7 @@ template <int N> struct vector_conversion_traits<bfloat16, N> {
     vector_type_t<RawT, N> Output = 0;
 
     for (int i = 0; i < N; i++) {
-      Output[i] = sycl::bit_cast<RawT>(Val[i]);
+      Output[i] = sycl::bit_cast<RawT>(static_cast<bfloat16>(Val[i]));
     }
     return Output;
 #endif // __SYCL_DEVICE_ONLY__

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ template <int N> struct vector_conversion_traits<bfloat16, N> {`
`58`	`58`	`vector_type_t<RawT, N> Output = 0;`
`59`	`59`
`60`	`60`	`for (int i = 0; i < N; i++) {`
`61`		`- Output[i] = sycl::bit_cast<RawT>(Val[i]);`
	`61`	`+ Output[i] = sycl::bit_cast<RawT>(static_cast<bfloat16>(Val[i]));`
`62`	`62`	`}`
`63`	`63`	`return Output;`
`64`	`64`	`#endif // __SYCL_DEVICE_ONLY__`