[SYCL][COMPAT] Addressed comments in #10774

- Added const variable: device name buffer size
(device_info::NAME_BUFFER_SIZE).
- get_major_version and get_minor_version calls follow the same
convention as the other get_ functions.
- Removed default handler when creating a queue with
`print_on_async_exceptions` set to false.
- device_fixt: .h -> .hpp
- Removed non-existing friend function free_async.
- Improved Readme.md with latest changes.
  - Fixed syclcompat include statement.

Author: Alcpz

sycl/doc/syclcompat/README.md

@@ -50,7 +50,7 @@ through the main header, `syclcompat.hpp`. Note that `syclcompat.hpp` does not
 import the <sycl/sycl.hpp> header.
 
 ``` cpp
-#include <sycl/syclcompat.hpp>
+#include <syclcompat.hpp>
 ```
 
 This document presents the public API under the [Features](#features) section,
@@ -768,8 +768,8 @@ The exposed functionalities include creation and destruction of queues, through
 `syclcompat::create_queue` and `syclcompat::destroy_queue`, and providing the
 ability to wait for submitted kernels using `syclcompat::wait` or
 `syclcompat::wait_and_throw`. Any async errors will be output to `stderr` if
-`print_on_async_exceptions`. Synchronous exceptions have to be managed by users
-independently of what is set in this parameter.
+`print_on_async_exceptions`, and will have the default behavior otherwise, which calls `std:terminate`. Synchronous exceptions have to be managed
+by users independently of what is set in this parameter.
 
 Devices are managed through a helper class, `device_ext`. The `device_ext` class
 associates a vector of `sycl::queues` with its `sycl::device`. The `device_ext`
@@ -1159,7 +1159,7 @@ using this library:
 #include <cassert>
 #include <iostream>
 
-#include <sycl/syclcompat.hpp>
+#include <syclcompat.hpp>
 #include <sycl/sycl.hpp>
 
 /**

sycl/include/syclcompat/device.hpp

@@ -143,7 +143,9 @@ class device_info {
   size_t get_global_mem_size() const { return _global_mem_size; }
   size_t get_local_mem_size() const { return _local_mem_size; }
   // set interface
-  void set_name(const char *name) { std::strncpy(_name, name, 256); }
+  void set_name(const char *name) {
+    std::strncpy(_name, name, device_info::NAME_BUFFER_SIZE);
+  }
   void set_max_work_item_sizes(const sycl::id<3> max_work_item_sizes) {
     _max_work_item_sizes = max_work_item_sizes;
     for (int i = 0; i < 3; ++i)
@@ -180,7 +182,9 @@ class device_info {
   }
 
 private:
-  char _name[256];
+  constexpr static size_t NAME_BUFFER_SIZE = 256;
+
+  char _name[device_info::NAME_BUFFER_SIZE];
   sycl::id<3> _max_work_item_sizes;
   int _max_work_item_sizes_i[3];
   int _major;
@@ -219,15 +223,11 @@ class device_ext : public sycl::device {
 
   bool is_native_host_atomic_supported() { return 0; }
   int get_major_version() const {
-    int major, minor;
-    get_version(major, minor);
-    return major;
+    return get_device_info().get_major_version();
   }
 
   int get_minor_version() const {
-    int major, minor;
-    get_version(major, minor);
-    return minor;
+    return get_device_info().get_minor_version();
   }
 
   int get_max_compute_units() const {
@@ -324,15 +324,16 @@ class device_ext : public sycl::device {
   queue_ptr create_queue(bool print_on_async_exceptions = false,
                          bool in_order = true) {
     std::lock_guard<std::mutex> lock(m_mutex);
-    sycl::async_handler eh = {};
     sycl::property_list prop = {};
-    if (print_on_async_exceptions) {
-      eh = detail::exception_handler;
-    }
     if (in_order) {
       prop = {sycl::property::queue::in_order()};
     }
-    _queues.push_back(std::make_shared<sycl::queue>(_ctx, *this, eh, prop));
+    if (print_on_async_exceptions) {
+      _queues.push_back(std::make_shared<sycl::queue>(
+          _ctx, *this, detail::exception_handler, prop));
+    } else {
+      _queues.push_back(std::make_shared<sycl::queue>(_ctx, *this, prop));
+    }
     return _queues.back().get();
   }
   void destroy_queue(queue_ptr &queue) {
@@ -388,8 +389,6 @@ class device_ext : public sycl::device {
     std::lock_guard<std::mutex> lock(m_mutex);
     _events.push_back(event);
   }
-  friend sycl::event free_async(const std::vector<void *> &,
-                                const std::vector<sycl::event> &, sycl::queue);
   queue_ptr _default_queue;
   queue_ptr _saved_queue;
   sycl::context _ctx;

sycl/test-e2e/syclcompat/device/device.cpp

@@ -34,7 +34,7 @@
 
 #include <syclcompat/device.hpp>
 
-#include "device_fixt.h"
+#include "device_fixt.hpp"
 
 int main() {
   /*

sycl/test-e2e/syclcompat/device/device_fixt.h renamed to sycl/test-e2e/syclcompat/device/device_fixt.hpp

@@ -36,7 +36,7 @@
 
 #include <syclcompat/device.hpp>
 
-#include "device_fixt.h"
+#include "device_fixt.hpp"
 
 int main() {
   // Check a thread is able to select a non-default device