Skip to content

Commit fe88f1d

Browse files
npmillermartygrant
andauthored
[SYCL][CUDA][HIP] Update images enable variable (#16147)
This patch adds a variable to enable image support for HIP, and updates the one for CUDA to use the UR naming. SYCL images support is similar for CUDA and HIP, so it makes sense to treat them the same, and any future work on this will focus on bindless images rather than SYCL images. UR side PR: oneapi-src/unified-runtime#2356 --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
1 parent 1587ea5 commit fe88f1d

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# commit 098deca1f9f3b9f3f0563ee823ac424d8db30668
2-
# Merge: 58e4d76c2ace 73ba29bfe9df
1+
# commit 06f48f674445532d8c04be431474901b82c3c449
2+
# Merge: 098deca1f9f3 1b373f83c71e
33
# Author: Martin Grant <[email protected]>
4-
# Date: Wed Dec 11 17:23:43 2024 +0000
5-
# Merge pull request #2299 from cppchedy/chedy/fix-mipmap-leak
6-
# [CUDA][Bindless] Fix memory leak in interop mapping
7-
set(UNIFIED_RUNTIME_TAG 098deca1f9f3b9f3f0563ee823ac424d8db30668)
4+
# Date: Thu Dec 12 11:04:15 2024 +0000
5+
# Merge pull request #2356 from npmiller/hip-images
6+
# [HIP] Disable SYCL images by default
7+
set(UNIFIED_RUNTIME_TAG 06f48f674445532d8c04be431474901b82c3c449)

sycl/test-e2e/format.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,10 @@ def get_extra_env(sycl_devices):
212212
)
213213

214214
if "cuda:gpu" in sycl_devices:
215-
extra_env.append("SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT=1")
215+
extra_env.append("UR_CUDA_ENABLE_IMAGE_SUPPORT=1")
216+
217+
if "hip:gpu" in sycl_devices:
218+
extra_env.append("UR_HIP_ENABLE_IMAGE_SUPPORT=1")
216219

217220
return extra_env
218221

sycl/test-e2e/lit.cfg.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,9 @@ def open_check_file(file_name):
666666
env = copy.copy(llvm_config.config.environment)
667667
env["ONEAPI_DEVICE_SELECTOR"] = sycl_device
668668
if sycl_device.startswith("cuda:"):
669-
env["SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT"] = "1"
669+
env["UR_CUDA_ENABLE_IMAGE_SUPPORT"] = "1"
670+
if sycl_device.startswith("hip:"):
671+
env["UR_HIP_ENABLE_IMAGE_SUPPORT"] = "1"
670672
# When using the ONEAPI_DEVICE_SELECTOR environment variable, sycl-ls
671673
# prints warnings that might derail a user thinking something is wrong
672674
# with their test run. It's just us filtering here, so silence them unless

0 commit comments

Comments
 (0)