Skip to content

[SYCL][UR] Disable UR_LAYER_PARAMETER_VALIDATION by default #15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[SYCL][UR] Disable UR_LAYER_PARAMETER_VALIDATION by default #15105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d80b5f
[SYCL][UR] Disable UR_LAYER_PARAMETER_VALIDATION by default
nrspruit Aug 15, 2024
685c6a9
[SYCL][UR] Fully remove enabling the validation layer thru the SYCL init
nrspruit Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sycl/cmake/modules/FetchUnifiedRuntime.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ if(SYCL_UR_USE_FETCH_CONTENT)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 76361a88a0af6502fe655144655b381260ea9706
# Merge: b4195cb 0db57da
# commit b766009add8dc41ad03e2a63be9f6ed40eea4c55 (HEAD, origin/main, origin/HEAD)
# Merge: 608e9184 c3c57284
# Author: Omar Ahmed <[email protected]>
# Date: Wed, 31 Jul 2024 14:26:38 +0100
# Merge pull request #1961 from DBDuncan/duncan/num-channels-mipmap-fix
# [Bindless][Exp] Fix urBindlessImagesImageGetInfoExp failing with mipmap images
set(UNIFIED_RUNTIME_TAG 76361a88a0af6502fe655144655b381260ea9706)
# Date: Tue Aug 27 16:30:04 2024 +0100
# Merge pull request #2011 from nrspruit/fix_opencl_usm_align_check
# [OpenCL] Fix USM alignment error check to occur always and return nulllptr
set(UNIFIED_RUNTIME_TAG b766009add8dc41ad03e2a63be9f6ed40eea4c55)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down
5 changes: 1 addition & 4 deletions sycl/source/detail/ur.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,9 @@ static void initializePlugins(std::vector<PluginPtr> &Plugins,
__SYCL_CHECK_OCL_CODE_NO_EXC(Call)

bool OwnLoaderConfig = false;
// If we weren't provided with a custom config handle create our own and
// enable full validation by default.
// If we weren't provided with a custom config handle create our own.
if(!LoaderConfig) {
CHECK_UR_SUCCESS(urLoaderConfigCreate(&LoaderConfig))
CHECK_UR_SUCCESS(urLoaderConfigEnableLayer(LoaderConfig,
"UR_LAYER_PARAMETER_VALIDATION"))
OwnLoaderConfig = true;
}

Expand Down
Loading