Skip to content

[NFC][SYCL] Re-generate sycl_symbols_linux.dump and sycl_symbols_windows.dump #18924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

[NFC][SYCL] Re-generate sycl_symbols_linux.dump and sycl_symbols_windows.dump #18924

merged 2 commits into from
Jun 12, 2025

Conversation

fabiomestre
Copy link
Contributor

No description provided.

@fabiomestre fabiomestre requested a review from a team as a code owner June 11, 2025 14:39
@fabiomestre fabiomestre requested a review from maarquitos14 June 11, 2025 14:39
@fabiomestre fabiomestre changed the title Sort linux symbols dump file [SYCL] Sort symbols dump for linux test Jun 11, 2025
@aelovikov-intel aelovikov-intel changed the title [SYCL] Sort symbols dump for linux test [NFC][SYCL] Re-generate sycl_symbols_linux.dump Jun 11, 2025
maarquitos14
maarquitos14 approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aelovikov-intel
Copy link
Contributor

@fabiomestre , something went wrong, ABI test now fails...

@fabiomestre
Copy link
Contributor Author

@fabiomestre , something went wrong, ABI test now fails...

I will have a look 👍

@fabiomestre fabiomestre force-pushed the fabio/sort_linux_dump branch from f5287c2 to d5e2576 Compare June 11, 2025 15:40
@fabiomestre
Copy link
Contributor Author

@fabiomestre , something went wrong, ABI test now fails...

@fabiomestre , something went wrong, ABI test now fails...

I will have a look 👍

Seems fixed now. The build I used to generate the first one was probably slightly outdated (from yesterday I think)

@aelovikov-intel
Copy link
Contributor

Seems fixed now. The build I used to generate the first one was probably slightly outdated (from yesterday I think)

Once Win build task finishes, it will produce an artifact with win symbols file. Can you please upload that as another revision of this PR? If you prefer not to do, that's fine. Just lin is better than nothing :)

@fabiomestre fabiomestre changed the title [NFC][SYCL] Re-generate sycl_symbols_linux.dump [NFC][SYCL] Re-generate sycl_symbols_linux.dump and sycl_symbols_windows.dump Jun 12, 2025
@fabiomestre
Copy link
Contributor Author

Seems fixed now. The build I used to generate the first one was probably slightly outdated (from yesterday I think)

Once Win build task finishes, it will produce an artifact with win symbols file. Can you please upload that as another revision of this PR? If you prefer not to do, that's fine. Just lin is better than nothing :)

I have updated the windows one as well now.

@aelovikov-intel aelovikov-intel merged commit 7ed78bf into intel:sycl Jun 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabiomestre @aelovikov-intel @maarquitos14