SYCL] Support specialization constants in the L0 plugin #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Defer L0 module creation/build until piProgramBuild/piProgramCompile. - Support build log extraction. - Support build options. Author: Sergey V Maslov <[email protected]> Signed-off-by: Artur Gainullin <[email protected]>
Author: Jaime Arteaga <[email protected]> Signed-off-by: Artur Gainullin <[email protected]>
|
Please do not review the first commit, it is covered by another PR. Also, we need to wait when GPU driver version will be >= https://github.com/intel/compute-runtime/releases/tag/20.22.16952 to enable spec constant LIT tests They are currently disabled for opencl also. |
|
@smaslov-intel Could you please review. |
smaslov-intel
previously approved these changes
Jul 1, 2020
smaslov-intel
approved these changes
Jul 2, 2020
againull
pushed a commit
to againull/llvm
that referenced
this pull request
May 4, 2023
Before reading Target function name operand of `DebugFunction` we need to make sure it's the translation of appropriate debug extension. Otherwise, we can get in a situation, where we do have 11 operands, but the last one is not a `String` with name, but the `DebugFunctionDeclaration`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@f990940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Jaime Arteaga [email protected]
Signed-off-by: Artur Gainullin [email protected]