Skip to content

[SYCL] Emit supressed warnings #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2020

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Oct 1, 2020

This PR updates FE tests related to the following warnings:

  • Passing kernel functions by value is deprecated in SYCL 2020.
  • Passing of kernel functions by reference is a SYCL 2020 extension.
  • SYCL 1.2.1 specification requires an explicit forward declaration for a kernel type name; your program may not be portable.

The updated tests include the mock <sycl.hpp> header file and call the kernel invocation functions defined in the mock header.

@srividya-sundaram srividya-sundaram changed the title [WIP] Emit supressed warnings [SYCL] Emit supressed warnings Oct 1, 2020
@srividya-sundaram srividya-sundaram marked this pull request as ready for review October 1, 2020 04:15
s-kanaev
s-kanaev previously approved these changes Oct 1, 2020
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RT tests changes LGTM.

Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM

@bader bader merged commit e6eed1a into intel:sycl Oct 1, 2020
@srividya-sundaram srividya-sundaram deleted the emit-supressed-warnings branch October 1, 2020 16:54
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 5, 2020
…_wrapper

* upstream/sycl: (1021 commits)
  [SYCL] Enable async_work_group_copy for scalar and vector bool types (intel#2582)
  [SYCL] Fix element type in handler::copy (intel#2590)
  [NFC][SYCL] Remove unnecessary if condition (intel#2585)
  [SYCL][NFC] Fix SYCL lit test execution on a system w/o GPU (intel#2584)
  [SYCL] Add error handling for non-uniform work group size case (intel#2569)
  [SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (intel#2555)
  [SYCL] Make Level-Zero events visible on the host (intel#2576)
  [Driver][SYCL][NFC] Add help information for -Wno-sycl-strict (intel#2570)
  [SYCL] Relax test to work in Win32 environment. (intel#2580)
  [SYCL] Emit suppressed warnings from SYCL headers (intel#2575)
  [SYCL][NFC] Cover more classes with ABI tests (intel#2577)
  [SYCL][ESIMD] Update ESIMD tests and add raw send support. (intel#2482)
  [SYCL] Make ESIMD on-device tests require linux,gpu,opencl. (intel#2560)
  [SYCL] Release commands with no dependencies after they're enqueued (intel#2492)
  [SYCL] Add multi-device and multi-platform support for SYCL_DEVICE_ALLOWLIST  (intel#2483)
  [SYCL] Try to enqueue host command depencies (intel#2561)
  [SYCL][ESIMD][NFC] Align namespace name with the spec guidelines (intel#2573)
  [SYCL][NFC] Add class layout ABI tests for memory objects (intel#2559)
  [SYCL] Change adress space for global variables (intel#2534)
  [NFC][SYCL] Fix comment. (intel#2541)
  ...
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
[CUDA][Bindless] Add support for device to device pitched copies and host to host copies
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
[CUDA][Bindless] Add support for device to device pitched copies and host to host copies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants