[SYCL] Use int instead of pi_mem_advice in (queue|handler)::mem_advise #4100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update these API signatures according to the SYCL 2020 spec. - Keep `queue::mem_advise(const void *, size_t, pi_mem_advice)`, which was available in previous releases, but mark it as deprecated.
dm-vodopyanov
approved these changes
Jul 14, 2021
bader
reviewed
Jul 14, 2021
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jul 18, 2024
We made a mistake several years ago by introducing `pi_mem_advice` argument into a public interface in intel#1239. This mistake was caught a year later and addressed in intel#4100, but unfortunately instead of removing this incorrect overload, it was deprecated. Even deprectation was done improperly, because this method is *not* deprecated in SYCL 2020 - it *doesn't exists* in SYCL 2020. This PR removes the method completely, even though our messaging was wrong. The assumption is that there are no actual users who went and used undocumented non-public `pi_mem_advice` in their codebases.
AlexeySachkov
added a commit
that referenced
this pull request
Jul 18, 2024
We made a mistake several years ago by introducing `pi_mem_advice` argument into a public interface in #1239. This mistake was caught a year later and addressed in #4100, but unfortunately instead of removing this incorrect overload, it was only deprecated. The deprecation wasn't done quite correctly, because this method is *not* deprecated in SYCL 2020 - it *doesn't exists* in SYCL 2020. This PR removes the method completely, even though our messaging was wrong. The assumption is that there are no actual users who went and used undocumented non-public `pi_mem_advice` in their codebases. This is patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue::mem_advise(const void *, size_t, pi_mem_advice), whichwas available in previous releases, but mark it as deprecated.
Test: intel/llvm-test-suite#359