Skip to content

[SYCL][Spec] Update the matrix spec based on new use argument #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
d2a898a
update the matrix spec based on new use argument
dkhaldi Aug 29, 2022
2e98eb6
update the matrix spec based on new use argument
dkhaldi Aug 29, 2022
45564bd
- Deprecate the old spec (no use) but keep document with no change un…
dkhaldi Aug 29, 2022
5eb53ed
address Jack's comments and corrections
dkhaldi Sep 9, 2022
90a04f5
replace matrix_use with use and matrix_layout with layout
dkhaldi Sep 9, 2022
40f8886
Move the order of use in joint matrix type to before the first option…
dkhaldi Sep 9, 2022
7843cff
Incorporate Jack's corrections
dkhaldi Sep 14, 2022
e227765
Incorporate some of Greg's comments. The other ones are still under d…
dkhaldi Sep 22, 2022
1e53a9c
Update the references in sycl/ReleaseNotes.md to point to the new mat…
dkhaldi Sep 22, 2022
b2b5750
Adding layout as template argument to load,store, mad functions
dkhaldi Sep 23, 2022
e9ac406
Adding clarification about layout based on Jack's review
dkhaldi Sep 23, 2022
867f280
Moving towards a more convergent API between AMX, XMX and CUDA backen…
dkhaldi Oct 6, 2022
db9cfda
typos correction
dkhaldi Oct 6, 2022
f5b3d83
For consistency, replace ctype with accumulatortype and joint_matrix_…
dkhaldi Oct 6, 2022
e8e652c
more typos
dkhaldi Oct 6, 2022
7ebe2a7
Change the names default sizes in the query from defaultM, defaultN, …
dkhaldi Oct 6, 2022
921df9e
remove layout::invalid as this was suggested for the implementation n…
dkhaldi Oct 11, 2022
95f06ba
Update sycl_ext_oneapi_matrix.asciidoc
dkhaldi Oct 11, 2022
0cb7462
put back layout::dynamic as the default, removed it by accident
dkhaldi Oct 11, 2022
8a5a253
Incorporate Jack's review comments
dkhaldi Oct 11, 2022
c5808b4
correct joint_matrix_mad signature
dkhaldi Oct 14, 2022
e05ade5
Add IsDecorated to multi_ptr type
dkhaldi Oct 17, 2022
3208d42
Merge remote-tracking branch 'intel_llvm/sycl' into use-doc
dkhaldi Oct 17, 2022
b156860
Add IsDecorated new argument to multi_ptr type
dkhaldi Oct 17, 2022
ebe5d8d
move deprecated extension to the deprecated folder based on Pavel's s…
dkhaldi Oct 21, 2022
9ce7273
Add an open question about how to deal with non portable scenarios in…
dkhaldi Oct 26, 2022
bc1c2cb
restrict layout, load and store to the portable API
dkhaldi Oct 27, 2022
f8a4587
clarification on the store in the text
dkhaldi Oct 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sycl/ReleaseNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ Release notes for commit range 23ca0c2..27f59d8
Level Zero, ESIMD emulator, HIP [2b0ebab376dc]
- Added support for `sycl::ext::intel::experimental::esimd_ballot` function
[0bbb091c1baa]
- Added initial support for [Tensorcore matrix extension](doc/extensions/experimental/sycl_ext_oneapi_matrix.asciidoc)
- Added initial support for [Tensorcore matrix extension](doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc)
[711ba58c30a8]

### Documentation
Expand Down Expand Up @@ -809,7 +809,7 @@ Release notes for commit range 4fc5ebe..bd68232
- Added [sRGBA support](doc/extensions/supported/sycl_ext_oneapi_srgb.asciidoc)
[e488327][191efdd]
- Added a preview feature implementation for the DPC++ experimental
[matrix extension](doc/extensions/experimental/sycl_ext_oneapi_matrix.asciidoc)
[matrix extension](doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc)
[7f218531] [a95f46d]
- Added support for SYCL 2020 exceptions [5c0f748][eef07606][5af8c43d]
- Added support for [sycl_ext_intel_bf16_conversion extension](doc/extensions/experimental/sycl_ext_intel_bf16_conversion.asciidoc)
Expand Down Expand Up @@ -1073,7 +1073,7 @@ Release notes for commit range 6a49170027fb..962909fe9e78
for querying of free device memory in LevelZero backend extension [fa428bf]
- Added [InvokeSIMD](doc/extensions/proposed/sycl_ext_oneapi_invoke_simd.asciidoc) and
[Uniform](doc/extensions/proposed/sycl_ext_oneapi_uniform.asciidoc) extensions [72e1611]
- Added [Matrix Programming Extension for DPC++ document](doc/extensions/experimental/sycl_ext_oneapi_matrix.asciidoc) [ace4c733]
- Added [Matrix Programming Extension for DPC++ document](doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc) [ace4c733]
- Implemented SYCL 2020 `sycl::span` [9356d53]
- Added [device-if](doc/extensions/proposed/sycl_ext_oneapi_device_if.asciidoc) extension
[4fb95fc]
Expand Down Expand Up @@ -1219,7 +1219,7 @@ Release notes for commit range 6a49170027fb..962909fe9e78
- Fixed build issue when CUDA 11 is used [f7224f1]
- Fixed caching of sub-devices in Level Zero backend[4c34f93]
- Fixed requesting of USM memory allocation info on CUDA [691f842]
- Fixed [`joint_matrix_mad`](doc/extensions/experimental/sycl_ext_oneapi_matrix.asciidoc)
- Fixed [`joint_matrix_mad`](doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc)
behaviour to return `A*B+C` instead of assigning the result to `C` [ea59c2b]
- Workaround an issue in Level Zero backend when event isn't waited upon its
completion but is queried for its status in an infinite loop [bfef316]
Expand Down
Loading