Fix thread handle leak on Windows (#133)

lmielick · web-flow · commit f3447dfd54fd · 2025-06-04T12:55:12.000+03:00
diff --git a/llvm/lib/Support/Windows/Threading.inc b/llvm/lib/Support/Windows/Threading.inc
@@ -41,6 +41,9 @@ void llvm_thread_join_impl(HANDLE hThread) {
   if (::WaitForSingleObject(hThread, INFINITE) == WAIT_FAILED) {
     ReportLastErrorFatal("WaitForSingleObject failed");
   }
+  if (::CloseHandle(hThread) == FALSE) {
+    ReportLastErrorFatal("CloseHandle failed");
+  }
 }
 
 void llvm_thread_detach_impl(HANDLE hThread) {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,9 @@ void llvm_thread_join_impl(HANDLE hThread) {`
`41`	`41`	`if (::WaitForSingleObject(hThread, INFINITE) == WAIT_FAILED) {`
`42`	`42`	`ReportLastErrorFatal("WaitForSingleObject failed");`
`43`	`43`	`}`
	`44`	`+ if (::CloseHandle(hThread) == FALSE) {`
	`45`	`+ ReportLastErrorFatal("CloseHandle failed");`
	`46`	`+ }`
`44`	`47`	`}`
`45`	`48`
`46`	`49`	`void llvm_thread_detach_impl(HANDLE hThread) {`