Skip to content

Update PCH enable logic #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2023
Merged

Update PCH enable logic #396

merged 5 commits into from
Mar 1, 2023

Conversation

haonanya
Copy link

@haonanya haonanya commented Jan 17, 2023 •
edited
Loading

Update PCH enable logic

1. Some extensions are GPU only, add macro to manage
2. Add corner cases that detects cl_khr_fp64

@haonanya haonanya force-pushed the main-update-pch branch 2 times, most recently from 8c93c7b to cf97ef9 Compare February 20, 2023 09:13
@haonanya haonanya changed the title Use macro to manage extensions Update PCH enable logic Feb 20, 2023
@haonanya haonanya requested review from cdai2 and wenju-he February 20, 2023 09:14
wenju-he
wenju-he reviewed Feb 21, 2023
View reviewed changes
@haonanya haonanya requested a review from fzou1 February 21, 2023 01:22
@haonanya1
Update PCH enable logic
c891e1d 
1. Some extensions are GPU only, add macro to manage
2. Add corner cases that detects cl_khr_fp64
@haonanya haonanya requested a review from wenju-he February 28, 2023 03:12
@haonanya
Copy link
Author

@cdai2, @hewj03, @fzou1 , the patch doesn't influence IGC build. macro PCH_EXTENSION offers a way to custom extension map.

wenju-he
wenju-he reviewed Feb 28, 2023
View reviewed changes
@haonanya haonanya requested a review from wenju-he February 28, 2023 11:46
wenju-he
wenju-he reviewed Mar 1, 2023
View reviewed changes
@haonanya haonanya requested a review from wenju-he March 1, 2023 03:06
wenju-he
wenju-he reviewed Mar 1, 2023
View reviewed changes
@haonanya haonanya requested a review from wenju-he March 1, 2023 04:00
wenju-he
wenju-he approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haonanya haonanya merged commit de0ea6d into intel:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenju-he wenju-he wenju-he approved these changes

@cdai2 cdai2 Awaiting requested review from cdai2

@fzou1 fzou1 Awaiting requested review from fzou1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haonanya @wenju-he @haonanya1