Stack calls are not necessary to be noinline

Anton Sidorenko · Anton Sidorenko · commit 381535d6c25c · 2021-12-07T16:35:38.000+03:00
If the stack call must not be inlined, NoInline attribute should be
added by the FE, but not by the SPIRV reader adapter.
diff --git a/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVReaderAdaptor.cpp b/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVReaderAdaptor.cpp
@@ -562,7 +562,6 @@ bool GenXSPIRVReaderAdaptor::processVCFunctionAttributes(Function &F) {
 
   if (VCINTR::AttributeList::hasFnAttr(Attrs, VCFunctionMD::VCStackCall)) {
     F.addFnAttr(FunctionMD::CMStackCall);
-    F.addFnAttr(Attribute::NoInline);
     dropFnAttribute(F, VCFunctionMD::VCStackCall);
   }
 
diff --git a/GenXIntrinsics/test/Adaptors/fun_attributes_transform_reader.ll b/GenXIntrinsics/test/Adaptors/fun_attributes_transform_reader.ll
@@ -48,7 +48,7 @@ define spir_kernel void @test_VCSLMSize() #6 {
   ret void
 }
 
-; CHECK-DAG: attributes #[[FATR_STACK_CALL_ATTR_IDX]] = { noinline "CMStackCall" }
+; CHECK-DAG: attributes #[[FATR_STACK_CALL_ATTR_IDX]] = { "CMStackCall" }
 ; CHECK-DAG: attributes #[[FATR_CALLABLE_ATTR_IDX]] = { "CMCallable" }
 ; CHECK-DAG: attributes #[[FATR_FC_ENTRY_IDX]] = { "CMEntry" }
 ; CHECK-DAG: attributes #[[FATR_SIMT_CALL_IDX]] = { "CMGenxSIMT" }

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,6 @@ bool GenXSPIRVReaderAdaptor::processVCFunctionAttributes(Function &F) {`
`562`	`562`
`563`	`563`	`if (VCINTR::AttributeList::hasFnAttr(Attrs, VCFunctionMD::VCStackCall)) {`
`564`	`564`	`F.addFnAttr(FunctionMD::CMStackCall);`
`565`		`- F.addFnAttr(Attribute::NoInline);`
`566`	`565`	`dropFnAttribute(F, VCFunctionMD::VCStackCall);`
`567`	`566`	`}`
`568`	`567`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ define spir_kernel void @test_VCSLMSize() #6 {`
`48`	`48`	`ret void`
`49`	`49`	`}`
`50`	`50`
`51`		`-; CHECK-DAG: attributes #[[FATR_STACK_CALL_ATTR_IDX]] = { noinline "CMStackCall" }`
	`51`	`+; CHECK-DAG: attributes #[[FATR_STACK_CALL_ATTR_IDX]] = { "CMStackCall" }`
`52`	`52`	`; CHECK-DAG: attributes #[[FATR_CALLABLE_ATTR_IDX]] = { "CMCallable" }`
`53`	`53`	`; CHECK-DAG: attributes #[[FATR_FC_ENTRY_IDX]] = { "CMEntry" }`
`54`	`54`	`; CHECK-DAG: attributes #[[FATR_SIMT_CALL_IDX]] = { "CMGenxSIMT" }`