Skip to content

Commit f0b9f26

Browse files
Update PR template w/ CONTRIBUTOR/REVIEWER division
1 parent 9a60f26 commit f0b9f26

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

docs/PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ Fixes #
44

55
---
66

7-
### Pull Request Review checklist (do not remove)
7+
### CONTRIBUTOR checklist (do not remove)
8+
Please complete for every pull request
89

910
* [ ] `npm run lint:fix` has been run and linting passes.
1011
* [ ] Mocha, Jest (Storyshots), and `components/component-docs.json` CI tests pass (`npm test`).
@@ -13,6 +14,15 @@ Fixes #
1314
* [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open [http://localhost:9001/](http://localhost:9001/).
1415
* [ ] Review tests are passing in the browser. Open [http://localhost:8001/](http://localhost:8001/).
1516
* [ ] Review markup conforms to [SLDS](https://www.lightningdesignsystem.com/) by looking at [DOM snapshot strings](https://facebook.github.io/jest/docs/en/snapshot-testing.html).
17+
18+
### REVIEWER checklist (do not remove)
19+
20+
* [ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and `components/component-docs.json` tests.
21+
* [ ] Tests have been added for new props to prevent regressions in the future. See [readme](https://github.com/salesforce/design-system-react/blob/master/tests/README.md).
22+
* [ ] Review the appropriate Storybook stories. Open [http://localhost:9001/](http://localhost:9001/).
23+
* [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open [http://localhost:9001/](http://localhost:9001/).
24+
* [ ] Review tests are passing in the browser. Open [http://localhost:8001/](http://localhost:8001/).
25+
* [ ] Review markup conforms to [SLDS](https://www.lightningdesignsystem.com/) by looking at [DOM snapshot strings](https://facebook.github.io/jest/docs/en/snapshot-testing.html).
1626
* [ ] Add year-first date and commit SHA to `last-slds-markup-review` in `package.json` and push.
1727
* [ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
1828
* [ ] Add year-first review date, and commit SHA, `last-accessibility-review`, to `package.json` and push.

0 commit comments

Comments
 (0)