Properly swallow errors

Author: isc-bsaviano

src/commands/project.ts

@@ -737,9 +737,9 @@ export async function modifyProject(
   }
 
   // Technically a project is a "document", so tell the server that we're opening it
-  await new StudioActions()
-    .fireProjectUserAction(api, project, OtherStudioAction.OpenedDocument)
-    .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+  await new StudioActions().fireProjectUserAction(api, project, OtherStudioAction.OpenedDocument).catch(() => {
+    // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+  });
 
   let items: ProjectItem[] = await api
     .actionQuery("SELECT Name, Type FROM %Studio.Project_ProjectItemsList(?,?) WHERE Type != 'GBL'", [project, "1"])

src/commands/unitTest.ts

@@ -279,7 +279,9 @@ async function childrenForServerSideFolderItem(
     // Technically a project is a "document", so tell the server that we're opening it
     await new StudioActions()
       .fireProjectUserAction(api, params.get("project"), OtherStudioAction.OpenedDocument)
-      .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+      .catch(() => {
+        // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+      });
     query =
       "SELECT DISTINCT CASE " +
       "WHEN $LENGTH(SUBSTR(Name,?),'.') > 1 THEN $PIECE(SUBSTR(Name,?),'.') " +

src/explorer/models/projectNode.ts

@@ -18,9 +18,9 @@ export class ProjectNode extends NodeBase {
     // Technically a project is a "document", so tell the server that we're opening it
     const api = new AtelierAPI(this.workspaceFolderUri);
     api.setNamespace(this.namespace);
-    await new StudioActions()
-      .fireProjectUserAction(api, this.label, OtherStudioAction.OpenedDocument)
-      .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+    await new StudioActions().fireProjectUserAction(api, this.label, OtherStudioAction.OpenedDocument).catch(() => {
+      // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+    });
 
     node = new ProjectRootNode(
       "Classes",

src/providers/FileSystemProvider/FileSearchProvider.ts

@@ -26,7 +26,9 @@ export class FileSearchProvider implements vscode.FileSearchProvider {
       // Technically a project is a "document", so tell the server that we're opening it
       await new StudioActions()
         .fireProjectUserAction(new AtelierAPI(options.folder), params.get("project"), OtherStudioAction.OpenedDocument)
-        .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+        .catch(() => {
+          // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+        });
       if (token.isCancellationRequested) {
         return;
       }

src/providers/FileSystemProvider/FileSystemProvider.ts

@@ -206,7 +206,9 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
         // Technically a project is a "document", so tell the server that we're opening it
         await new StudioActions()
           .fireProjectUserAction(api, params.get("project"), OtherStudioAction.OpenedDocument)
-          .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+          .catch(() => {
+            // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+          });
       }
 
       // Get all items in the project

src/providers/FileSystemProvider/TextSearchProvider.ts

@@ -400,7 +400,9 @@ export class TextSearchProvider implements vscode.TextSearchProvider {
       // Technically a project is a "document", so tell the server that we're opening it
       await new StudioActions()
         .fireProjectUserAction(api, params.get("project"), OtherStudioAction.OpenedDocument)
-        .catch(/* Swallow error because showing it is more disruptive than using a potentially outdated project definition */);
+        .catch(() => {
+          // Swallow error because showing it is more disruptive than using a potentially outdated project definition
+        });
     }
     if (token.isCancellationRequested) {
       return;